You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
split_comma_string: change it to return vector of std::string_view (small effect probably)
instructions like m_objection = std::bitset<num_purposes>(std::stoull(std::string(token))); : Is there any way to avoid copying? Check their frequency to determine whether it makes sense
query_rewriter: can we simply change the result in place? We might have an issue with the sizing. Maybe copy only when resizing is needed.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
split_comma_string
: change it to return vector ofstd::string_view
(small effect probably)m_objection = std::bitset<num_purposes>(std::stoull(std::string(token)));
: Is there any way to avoid copying? Check their frequency to determine whether it makes sensequery_rewriter
: can we simply change the result in place? We might have an issue with the sizing. Maybe copy only when resizing is needed.Beta Was this translation helpful? Give feedback.
All reactions