Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum size of commands is just too low #6648

Closed
Jiralite opened this issue Feb 9, 2024 · 6 comments
Closed

Maximum size of commands is just too low #6648

Jiralite opened this issue Feb 9, 2024 · 6 comments
Labels
bug slash commands synced Synced to internal tracker

Comments

@Jiralite
Copy link
Contributor

Jiralite commented Feb 9, 2024

Description

I'm bringing the discussion #4070 into an issue. The points made there still stand.

I also have this unfortunate issue where I cannot localise my commands any further without seriously dumbing down or even removing locales from my bot. I am translating across more than 5 locales, more of which have fewer translations. Also, I want to point out that not all my commands are even localised, and I have a total of about 15 commands.

The catalyst for opening this was #6577. My bot has Spanish as the most translated locale. This would only result in a few modifications (or simply none at all) which essentially duplicates my es-ES payload in terms of size. The maximum size by Discord however is still the same. I'm sure people will want to switch to their natural choice—what are we supposed to do in this case?

I feel there should have been an increase in the maximum allowed size, or at least offer an alternative for developers to ship translations.

Steps to Reproduce

  1. Have a bot
  2. Localise it

Expected Behavior

Discord should allow bigger payloads for localisation (or explore alternatives).

Current Behavior

APPLICATION_COMMAND_TOO_LARGE.

spiderman-crying

Screenshots/Videos

No response

Client and System Information

N/A

@jhgg
Copy link
Contributor

jhgg commented Feb 9, 2024

How much more of an increase do you need?

@kyranet
Copy link
Contributor

kyranet commented Feb 9, 2024

I faced a similar issue, my bots support all 31 languages, and I have to make very small commands because otherwise they error with the aforementioned error.

Just recently, I doubled the limit with a command with 6 subcommands with 3 options (2 string with localised choices, and 1 number) for a command the likes of /convert mass, /convert length...

About 2 months ago the same command failed to register (with just 4 subcommands) as a result of being on the edge of 4000 characters and a French translator increasing the amount of characters slightly.

@Jiralite
Copy link
Contributor Author

Jiralite commented Feb 9, 2024

How much more of an increase do you need?

Is it possible to remove locales counting towards the total size? There would still be a limit in this case as locales can only exist with commands and a maximum string length is still enforced on them.

If not, we could start by tripling the existing limit?

@Rapptz
Copy link
Contributor

Rapptz commented Feb 9, 2024

Only the maximum value (including localisations) counts towards the limit. It's not the sum of all of them.

@jhgg
Copy link
Contributor

jhgg commented Feb 11, 2024

If not, we could start by tripling the existing limit?

We plan to double it next week. If this still isn't sufficient and the system remains healthy with this updated limit we will increase it further.

@matthova matthova added the synced Synced to internal tracker label Feb 15, 2024
@jhgg
Copy link
Contributor

jhgg commented Feb 15, 2024

We shipped a doubling of the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug slash commands synced Synced to internal tracker
Projects
None yet
Development

No branches or pull requests

6 participants