Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example docker commands due to deprecated "--link" flag #697

Closed
MatanSilver opened this issue Aug 1, 2020 · 2 comments
Closed

Update example docker commands due to deprecated "--link" flag #697

MatanSilver opened this issue Aug 1, 2020 · 2 comments

Comments

@MatanSilver
Copy link

In the single-process and multiiprocess links below, the example docker invokations use the "--link" flag, which is being deprecated by docker per [0]
https://github.com/huginn/huginn/tree/master/docker/single-process
https://github.com/huginn/huginn/tree/master/docker/multi-process

[0] https://docs.docker.com/network/links/

It seems based on docker's notice here that the recommended way to do this now would be either to connect to the database using a network and exposed port, or perhaps sharing mysqld.sock in a volume. Based on the error message I see when I remove the link flag, it appears that huginn is configured to use the socket directly, and might require some changes to connect to the database over the network? I'm not sure. Because of this I spent some time trying to get it to work with docker volumes to share mysqld.sock between the database container and the huginn container, but I haven't made much progress, so any pointers would be appreciated.

@wglambert
Copy link

Did you mean to make an issue over at https://github.com/huginn/huginn/issues?

The mysql image docs dropped the --link examples last year docker-library/docs#1441 from the discussion in #545 (comment)

Also https://github.com/docker-library/faq/blob/master/README.md#--link-is-deprecated

The documentation for "legacy container links" (--link) include a large warning about --link potentially going away at some point, but there is no timeline given and this "soft deprecation" has been going strong for a very long time. Their usage is definitely discouraged, but we expect Docker will continue to support them for quite some time.

@MatanSilver
Copy link
Author

Oh you are correct! I must have opened it in the wrong tab. My apologies and thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants