-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COPY note for --exclude feels/is misleading #22055
Comments
Thanks for reporting! So the version scheme for these is that I agree though that mentioning the version here (where a later stable version is available) can be somewhat confusing (we had some disussions around similar cases); given that it's very rare for the feature to be removed, in a later version, perhaps it's better to list these as @crazy-max @colinhemmings WDYT? |
Thanks for the detailed explanation! My initial thought was that Maybe change the options listing table to something like
And once it makes it into stable the N/A can be updated (and labs reference removed ?) |
Thanks! Yes, I (personally) think a table like that could help. In general, I tend to avoid mentioning versions too much (at least in examples), because in my experience, users copy/paste the example, and never think of updating their Dockerfile again, so now locked themselves into an old version of the Dockerfile syntax (either labs or stable), and never receive updates and bug fixes. There's definitely situations where that's desired (pin to a fixed version, and only update when needed), but it's also really easy to forget updating 😅 (and now being confused "why does this example from the docs not work in MY Dockerfile?"). |
Coincidently, that's exactly how I ended up raising this issue. |
Is this a docs issue?
Type of issue
Information is incorrect
Description
The note about not being available in stable syntax seems in contradiction with https://docs.docker.com/reference/dockerfile/#copy which states 'from 1.7-labs' (implying that 1.8 has this syntax)
https://docs.docker.com/reference/dockerfile/#copy---exclude
Location
https://docs.docker.com/reference/dockerfile/
Suggestion
No response
The text was updated successfully, but these errors were encountered: