Reinstate SQLServerPlatform and SQLServerKeywords

Author: morozov

UPGRADE.md

@@ -11,6 +11,7 @@ awareness about deprecated code.
 ## Deprecated versioned platform classes that represent the lowest supported version:
 
 1. `PostgreSQL94Platform` and `PostgreSQL94Keywords`. Use `PostgreSQLPlatform` and `PostgreSQLKeywords` instead.
+2. `SQLServer2012Platform` and `SQLServer2012Keywords`. Use `SQLServerPlatform` and `SQLServerKeywords` instead.
 
 ## Deprecated schema comparison APIs that don't account for the current database connection and the database platform
 

docs/en/reference/platforms.rst

@@ -50,7 +50,7 @@ Oracle
 Microsoft SQL Server
 ^^^^^^^^^^^^^^^^^^^^
 
--  ``SQLServer2012Platform`` for version 2012 and above.
+-  ``SQLServerPlatform`` for version 2012 and above.
 
 PostgreSQL
 ^^^^^^^^^^

phpstan.neon.dist

@@ -83,7 +83,7 @@ parameters:
         -
             message: '~^Only numeric types are allowed in -, int<1, max>\|false given on the left side\.~'
             paths:
-                - %currentWorkingDirectory%/src/Platforms/SQLServer2012Platform.php
+                - %currentWorkingDirectory%/src/Platforms/SQLServerPlatform.php
 
         # Unlike Psalm, PHPStan doesn't understand the shape of the parse_str() return value
         -
@@ -95,7 +95,7 @@ parameters:
         -
             message: '~^Only numeric types are allowed in pre\-decrement, int\<1, max\>\|false given\.$~'
             paths:
-                - %currentWorkingDirectory%/src/Platforms/SQLServer2012Platform.php
+                - %currentWorkingDirectory%/src/Platforms/SQLServerPlatform.php
 
         # https://github.com/phpstan/phpstan-phpunit/issues/83
         -

psalm.xml.dist

@@ -65,7 +65,9 @@
                     TODO: remove in 4.0.0
                 -->
                 <referencedClass name="Doctrine\DBAL\Platforms\Keywords\PostgreSQL94Keywords"/>
+                <referencedClass name="Doctrine\DBAL\Platforms\Keywords\SQLServer2012Keywords"/>
                 <referencedClass name="Doctrine\DBAL\Platforms\PostgreSQL94Platform"/>
+                <referencedClass name="Doctrine\DBAL\Platforms\SQLServer2012Platform"/>
             </errorLevel>
         </DeprecatedClass>
         <DeprecatedInterface>
@@ -182,7 +184,7 @@
                 <file name="src/DriverManager.php"/>
                 <file name="src/Platforms/AbstractPlatform.php"/>
                 <file name="src/Platforms/MySQLPlatform.php"/>
-                <file name="src/Platforms/SQLServer2012Platform.php"/>
+                <file name="src/Platforms/SQLServerPlatform.php"/>
                 <file name="src/Platforms/SqlitePlatform.php"/>
                 <file name="src/Schema/Column.php"/>
                 <!--

src/Platforms/Keywords/SQLServer2012Keywords.php

@@ -4,210 +4,9 @@
 
 /**
  * Microsoft SQL Server 2012 reserved keyword dictionary.
+ *
+ * @deprecated Use {@link SQLServerKeywords} instead.
  */
-class SQLServer2012Keywords extends KeywordList
+class SQLServer2012Keywords extends SQLServerKeywords
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function getName()
-    {
-        return 'SQLServer';
-    }
-
-    /**
-     * {@inheritdoc}
-     *
-     * @link http://msdn.microsoft.com/en-us/library/aa238507%28v=sql.80%29.aspx
-     */
-    protected function getKeywords()
-    {
-        return [
-            'ADD',
-            'ALL',
-            'ALTER',
-            'AND',
-            'ANY',
-            'AS',
-            'ASC',
-            'AUTHORIZATION',
-            'BACKUP',
-            'BEGIN',
-            'BETWEEN',
-            'BREAK',
-            'BROWSE',
-            'BULK',
-            'BY',
-            'CASCADE',
-            'CASE',
-            'CHECK',
-            'CHECKPOINT',
-            'CLOSE',
-            'CLUSTERED',
-            'COALESCE',
-            'COLLATE',
-            'COLUMN',
-            'COMMIT',
-            'COMPUTE',
-            'CONSTRAINT',
-            'CONTAINS',
-            'CONTAINSTABLE',
-            'CONTINUE',
-            'CONVERT',
-            'CREATE',
-            'CROSS',
-            'CURRENT',
-            'CURRENT_DATE',
-            'CURRENT_TIME',
-            'CURRENT_TIMESTAMP',
-            'CURRENT_USER',
-            'CURSOR',
-            'DATABASE',
-            'DBCC',
-            'DEALLOCATE',
-            'DECLARE',
-            'DEFAULT',
-            'DELETE',
-            'DENY',
-            'DESC',
-            'DISK',
-            'DISTINCT',
-            'DISTRIBUTED',
-            'DOUBLE',
-            'DROP',
-            'DUMP',
-            'ELSE',
-            'END',
-            'ERRLVL',
-            'ESCAPE',
-            'EXCEPT',
-            'EXEC',
-            'EXECUTE',
-            'EXISTS',
-            'EXIT',
-            'EXTERNAL',
-            'FETCH',
-            'FILE',
-            'FILLFACTOR',
-            'FOR',
-            'FOREIGN',
-            'FREETEXT',
-            'FREETEXTTABLE',
-            'FROM',
-            'FULL',
-            'FUNCTION',
-            'GOTO',
-            'GRANT',
-            'GROUP',
-            'HAVING',
-            'HOLDLOCK',
-            'IDENTITY',
-            'IDENTITY_INSERT',
-            'IDENTITYCOL',
-            'IF',
-            'IN',
-            'INDEX',
-            'INNER',
-            'INSERT',
-            'INTERSECT',
-            'INTO',
-            'IS',
-            'JOIN',
-            'KEY',
-            'KILL',
-            'LEFT',
-            'LIKE',
-            'LINENO',
-            'LOAD',
-            'MERGE',
-            'NATIONAL',
-            'NOCHECK ',
-            'NONCLUSTERED',
-            'NOT',
-            'NULL',
-            'NULLIF',
-            'OF',
-            'OFF',
-            'OFFSETS',
-            'ON',
-            'OPEN',
-            'OPENDATASOURCE',
-            'OPENQUERY',
-            'OPENROWSET',
-            'OPENXML',
-            'OPTION',
-            'OR',
-            'ORDER',
-            'OUTER',
-            'OVER',
-            'PERCENT',
-            'PIVOT',
-            'PLAN',
-            'PRECISION',
-            'PRIMARY',
-            'PRINT',
-            'PROC',
-            'PROCEDURE',
-            'PUBLIC',
-            'RAISERROR',
-            'READ',
-            'READTEXT',
-            'RECONFIGURE',
-            'REFERENCES',
-            'REPLICATION',
-            'RESTORE',
-            'RESTRICT',
-            'RETURN',
-            'REVERT',
-            'REVOKE',
-            'RIGHT',
-            'ROLLBACK',
-            'ROWCOUNT',
-            'ROWGUIDCOL',
-            'RULE',
-            'SAVE',
-            'SCHEMA',
-            'SECURITYAUDIT',
-            'SELECT',
-            'SEMANTICKEYPHRASETABLE',
-            'SEMANTICSIMILARITYDETAILSTABLE',
-            'SEMANTICSIMILARITYTABLE',
-            'SESSION_USER',
-            'SET',
-            'SETUSER',
-            'SHUTDOWN',
-            'SOME',
-            'STATISTICS',
-            'SYSTEM_USER',
-            'TABLE',
-            'TABLESAMPLE',
-            'TEXTSIZE',
-            'THEN',
-            'TO',
-            'TOP',
-            'TRAN',
-            'TRANSACTION',
-            'TRIGGER',
-            'TRUNCATE',
-            'TRY_CONVERT',
-            'TSEQUAL',
-            'UNION',
-            'UNIQUE',
-            'UNPIVOT',
-            'UPDATE',
-            'UPDATETEXT',
-            'USE',
-            'USER',
-            'VALUES',
-            'VARYING',
-            'VIEW',
-            'WAITFOR',
-            'WHEN',
-            'WHERE',
-            'WHILE',
-            'WITH',
-            'WITHIN GROUP',
-            'WRITETEXT',
-        ];
-    }
 }