Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL table engine not changed #4945

Open
aimeos opened this issue Nov 2, 2021 · 5 comments
Open

MySQL table engine not changed #4945

aimeos opened this issue Nov 2, 2021 · 5 comments

Comments

@aimeos
Copy link
Contributor

aimeos commented Nov 2, 2021

Bug Report

Q A
BC Break no
Version 3.1.3

Summary

The SQL for changing the MySQL table engine isn't generated if this is the only change for the table, e.g. from MyISAM to InnoDB

Current behaviour

No SQL statement for changing the MySQL table engine is generated

How to reproduce

$platform = $conn->getDatabasePlatform();
$schema = $schemaManager->createSchema();

$modifiedSchema = clone $schema;
$modifiedSchema->getTable( 'testtable' )->addOption( 'engine', 'InnoDB' );
$sql = $schema->getMigrateToSql( $modifiedSchema, $platform );

Expected behaviour

Should generate SQL statement:

ALTER TABLE testtable ENGINE=InnoDB
@morozov
Copy link
Member

morozov commented Nov 2, 2021

Fixing this bug requires the logic implemented in #4746 regarding column SQL declarations to be implemented for table SQL declarations.

@arderyp
Copy link

arderyp commented Feb 20, 2022

hows this going? I am still seeing a broken up() generation due to this bug

@morozov
Copy link
Member

morozov commented Feb 20, 2022

I don’t believe anybody is working on this issue.

@arderyp
Copy link

arderyp commented Feb 20, 2022

I can try to take a closer look when I have more time, but would be awesome if someone who is more familiar with the code base could chime in

@arderyp
Copy link

arderyp commented Jul 15, 2022

For what it is worth, my issue with collation junk populating my down() function was somehow resolved for me somewhere in the process of upgrading from Symfony 4.4 to 5.4, which updated various Doctrine dependencies. I appreciate everyone's feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants