Deprecate AttributeDriver::$entityAnnotationClasses

Author: greg0ire

UPGRADE.md

@@ -1,5 +1,10 @@
 # Upgrade to 2.14
 
+## Deprecated `AttributeDriver::$entityAnnotationClasses`
+
+If you need to change the behavior of `AttributeDriver::isTransient()`,
+override that method instead.
+
 ## Deprecated incomplete schema updates
 
 Using `orm:schema-tool:update` without passing the `--complete` flag is

lib/Doctrine/ORM/Mapping/Driver/AttributeDriver.php

@@ -31,7 +31,16 @@ class AttributeDriver extends CompatibilityAnnotationDriver
 {
     use ColocatedMappingDriver;
 
-    /** @var array<class-string<MappingAttribute>, int> */
+    private const ENTITY_ATTRIBUTE_CLASSES = [
+        Mapping\Entity::class => 1,
+        Mapping\MappedSuperclass::class => 2,
+    ];
+
+    /**
+     * @deprecated override isTransient() instead of overriding it
+     *
+     * @var array<class-string<MappingAttribute>, int>
+     */
     protected $entityAnnotationClasses = [
         Mapping\Entity::class => 1,
         Mapping\MappedSuperclass::class => 2,
@@ -58,6 +67,15 @@ public function __construct(array $paths)
 
         $this->reader = new AttributeReader();
         $this->addPaths($paths);
+
+        if ($this->entityAnnotationClasses !== self::ENTITY_ATTRIBUTE_CLASSES) {
+            Deprecation::trigger(
+                'doctrine/orm',
+                'https://github.com/doctrine/orm/pull/10204',
+                'Changing the value of %s::$entityAnnotationClasses is deprecated and will have no effect in Doctrine ORM 3.0.',
+                self::class
+            );
+        }
     }
 
     /**
@@ -88,7 +106,7 @@ public function isTransient($className)
 
         foreach ($classAttributes as $a) {
             $attr = $a instanceof RepeatableAttributeCollection ? $a[0] : $a;
-            if (isset($this->entityAnnotationClasses[get_class($attr)])) {
+            if (isset($this->entityAttributeClasses[get_class($attr)])) {
                 return false;
             }
         }