Skip to content

Commit b2f14c6

Browse files
committed
Address PHPStan complaints
1 parent 8beab61 commit b2f14c6

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

src/Query/Parser.php

+1
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,7 @@ public function parse()
408408
SqlFinalizer::class
409409
);
410410
$executor = $outputWalker->getExecutor($AST);
411+
// @phpstan-ignore method.deprecated
411412
$this->parserResult->setSqlExecutor($executor);
412413
}
413414

src/Query/SqlWalker.php

+2
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,8 @@ public function setQueryComponent($dqlAlias, array $queryComponent)
278278
* @param AST\DeleteStatement|AST\UpdateStatement|AST\SelectStatement $AST
279279
*
280280
* @return Exec\AbstractSqlExecutor
281+
*
282+
* @not-deprecated
281283
*/
282284
public function getExecutor($AST)
283285
{

tests/Tests/ORM/Functional/ParserResultSerializationTest.php

+7-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66

77
use Closure;
88
use Doctrine\ORM\Query;
9-
use Doctrine\ORM\Query\Exec\SingleSelectExecutor;
9+
use Doctrine\ORM\Query\Exec\FinalizedSelectExecutor;
10+
use Doctrine\ORM\Query\Exec\PreparedExecutorFinalizer;
11+
use Doctrine\ORM\Query\Exec\SqlFinalizer;
1012
use Doctrine\ORM\Query\ParserResult;
1113
use Doctrine\ORM\Query\ResultSetMapping;
1214
use Doctrine\Tests\OrmFunctionalTestCase;
@@ -143,11 +145,12 @@ public static function provideSerializedSingleSelectResults(): Generator
143145

144146
public function testSymfony44ProvidedData(): void
145147
{
146-
$sqlExecutor = $this->createMock(SingleSelectExecutor::class);
148+
$sqlExecutor = new FinalizedSelectExecutor('test');
149+
$sqlFinalizeer = new PreparedExecutorFinalizer($sqlExecutor);
147150
$resultSetMapping = $this->createMock(ResultSetMapping::class);
148151

149152
$parserResult = new ParserResult();
150-
$parserResult->setSqlExecutor($sqlExecutor);
153+
$parserResult->setSqlFinalizer($sqlFinalizeer);
151154
$parserResult->setResultSetMapping($resultSetMapping);
152155
$parserResult->addParameterMapping('name', 0);
153156

@@ -157,7 +160,7 @@ public function testSymfony44ProvidedData(): void
157160
$this->assertInstanceOf(ParserResult::class, $unserialized);
158161
$this->assertInstanceOf(ResultSetMapping::class, $unserialized->getResultSetMapping());
159162
$this->assertEquals(['name' => [0]], $unserialized->getParameterMappings());
160-
$this->assertInstanceOf(SingleSelectExecutor::class, $unserialized->getSqlExecutor());
163+
$this->assertEquals($sqlExecutor, $unserialized->prepareSqlExecutor($this->createMock(Query::class)));
161164
}
162165

163166
private static function parseQuery(Query $query): ParserResult

0 commit comments

Comments
 (0)