[PHPDoc] Parameter #4 of method QueryBuilder::innerJoin() expects string|null, Func given.

[soullivaneuh]

Bug Report

Q	A
BC Break	no
Version	v2.7.2

Summary

The QueryBuilder::innerJoin does not expect Doctrine\ORM\Query\Expr\Func #4 parameter type according to the PHPDoc.

This typing should be added for a stronger typing and to make tools like PHPStan happier.

Current behavior

PHPStan error:

Parameter #4 $condition of method Doctrine\ORM\QueryBuilder::innerJoin() expects string|null, Doctrine\ORM\Query\Expr\Func given.

How to reproduce

Related code producing the error (currently working properly):

$qb = $this->getRepository(PowerDNSRecord::class)->createQueryBuilder('r');
$qb->innerJoin('r.domain', 'd', Expr\Join::WITH, $qb->expr()->in('d.name', ':domains'))
    ->select('d.name, r.content, r.type')
    ->where($qb->expr()->in('r.type', ':types'))
    ->andWhere('r.name = d.name')
    ->setParameters(['domains' => $hostings, 'types' => ['A', 'AAAA']])
;

Expected behavior

Everything should be ok as the method works with a func.

[najmi9]

The same problem, any updates?