Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs | Undocumented API Functionality in SqlClientFactory for CreateDataSourceEnumerator #2346

Open
H-Yeo opened this issue Feb 7, 2024 · 0 comments
Labels
Area\Documentation Issue that requires changes in public documentations/samples. 🙌 Up-for-Grabs Issues that are ready to be picked up for anyone interested. Please self-assign and remove the label

Comments

@H-Yeo
Copy link
Contributor

H-Yeo commented Feb 7, 2024

Describe the bug

While reviewing Microsoft documentation,
SqlClientFactory.cs (implementation) and SqlClientFactory.xml (documentation) the following method:
C# public override DbDataSourceEnumerator CreateDataSourceEnumerator()

.NET Core project reference is missing this implementation
../netcore/ref/Microsoft.Data.SqlClient.cs

.NET FX project reference has this implementation
../netfx/ref/Microsoft.Data.SqlClient.cs

The original commit hash was from 2019:
d6f2e29

To reproduce

Review Documentation between .NET Core and .NET FX
Documentation References:

.NET Core (missing) - Expand Methods:
https://learn.microsoft.com/en-us/dotnet/api/microsoft.data.sqlclient?view=sqlclient-dotnet-core-5.1

.NET FX (available) - Expand Methods:
https://learn.microsoft.com/en-us/dotnet/api/microsoft.data.sqlclient?view=sqlclient-dotnet-5.1

Expected behavior

Missing method for .NET Core documentation is updated to be similar/identical to .NET FX documentation.

Further technical details

Microsoft.Data.SqlClient version: 5.2 (Preview)
.NET target: .NET Core 3.0+ (could be earlier, going off the commit here)
SQL Server version: n/a
Operating system: n/a

Additional context
Fix, Add missing reference for .NET Core
MDS team generates API Documentation and verify it's published

@JRahnama JRahnama added 🆕 Triage Needed For new issues, not triaged yet. Area\Documentation Issue that requires changes in public documentations/samples. 🙌 Up-for-Grabs Issues that are ready to be picked up for anyone interested. Please self-assign and remove the label and removed 🆕 Triage Needed For new issues, not triaged yet. labels Feb 8, 2024
@github-project-automation github-project-automation bot moved this to Needs Investigation in SqlClient Triage Board Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Documentation Issue that requires changes in public documentations/samples. 🙌 Up-for-Grabs Issues that are ready to be picked up for anyone interested. Please self-assign and remove the label
Projects
Status: Needs Investigation
Development

No branches or pull requests

2 participants