Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a NuGet package README to distinguish and inform consumers on each SQLClient package #2764

Closed
JonDouglas opened this issue Aug 9, 2024 · 4 comments · Fixed by #2826
Closed
Labels
💡 Enhancement Issues that are feature requests for the drivers we maintain.

Comments

@JonDouglas
Copy link

I was reading through this tweet in which consumers weren't aware of the differences of System/Microsoft packages:

https://x.com/terrajobst/status/1821683056115376129

#1963

We recently have added README functionality to NuGet.org and soon you will be able to view these READMEs in your favorite IDE/editor experience as well like Visual Studio & VS Code.

It may be worth adding package READMEs to both packages for their next update to describe these packages further and what scenarios one should use them with. Here's a blog with more information on this:

https://devblogs.microsoft.com/nuget/write-a-high-quality-readme-for-nuget-packages/

@arellegue arellegue added the 🆕 Triage Needed For new issues, not triaged yet. label Aug 12, 2024
@arellegue
Copy link
Contributor

arellegue commented Aug 12, 2024

Thank you for raising the issue that consumers of Microsoft.Data.SqlClient package might not be aware of the differences of System/Microsoft packages.

The porting-cheat-sheet from System.Data.SqlClient to Microsoft.Data.SqlClient should help to introduce the difference between the two packages. This cheat-sheet is already referenced in the README. We will discuss if the nuget package README should be updated with the same information.

@JRahnama
Copy link
Contributor

@JonDouglas I've been considering this. Thank you for bringing it up. I will test it to see how it works. I’m fairly certain that snupkg files (pdbs) do not include READMEs, but at least the nupkg package will have that feature.

@JRahnama
Copy link
Contributor

@JonDouglas to add more we can only do this on Microsoft.Data.SqlClient

@JonDouglas
Copy link
Author

You should be able to use the old README experience for the older package and use the new one for packages that are actively built!

@kf-gonzalez2 kf-gonzalez2 added 💡 Enhancement Issues that are feature requests for the drivers we maintain. and removed 🆕 Triage Needed For new issues, not triaged yet. labels Aug 13, 2024
@github-project-automation github-project-automation bot moved this to Needs Investigation in SqlClient Triage Board Aug 28, 2024
@JRahnama JRahnama linked a pull request Aug 30, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Needs Investigation to Closed in SqlClient Triage Board Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement Issues that are feature requests for the drivers we maintain.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants