Skip to content

Commit bc0bd0a

Browse files
authored
Add result for target stop event trace (#11202)
Fixes #10975 Context The stop events didn't report success or failure. Changes Made Pass parameter currentTargetEntry.Result.ResultCode.ToString() to the event log
1 parent 89b8461 commit bc0bd0a

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/Build/BackEnd/Components/RequestBuilder/TargetBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ private async Task ProcessTargetStack(ITaskBuilder taskBuilder)
484484
// Execute all of the tasks on this target.
485485
MSBuildEventSource.Log.TargetStart(currentTargetEntry.Name);
486486
await currentTargetEntry.ExecuteTarget(taskBuilder, _requestEntry, _projectLoggingContext, _cancellationToken);
487-
MSBuildEventSource.Log.TargetStop(currentTargetEntry.Name);
487+
MSBuildEventSource.Log.TargetStop(currentTargetEntry.Name, currentTargetEntry.Result?.ResultCode.ToString() ?? string.Empty);
488488
}
489489

490490
break;

src/Framework/MSBuildEventSource.cs

+4-3
Original file line numberDiff line numberDiff line change
@@ -362,10 +362,11 @@ public void TargetStart(string targetName)
362362
}
363363

364364
/// <param name="targetName">The name of the target being executed.</param>
365-
[Event(44, Keywords = Keywords.All | Keywords.PerformanceLog)]
366-
public void TargetStop(string targetName)
365+
/// <param name="result">Target stop result.</param>
366+
[Event(44, Keywords = Keywords.All | Keywords.PerformanceLog, Version = 1)]
367+
public void TargetStop(string targetName, string result)
367368
{
368-
WriteEvent(44, targetName);
369+
WriteEvent(44, targetName, result);
369370
}
370371

371372
/// <summary>

0 commit comments

Comments
 (0)