syntax

JanProvaznik · JanProvaznik · commit ed558963d606 · 2025-02-24T18:02:16.000+01:00
diff --git a/src/Build/BackEnd/BuildManager/BuildManager.cs b/src/Build/BackEnd/BuildManager/BuildManager.cs
@@ -1143,7 +1143,7 @@ private void EndBuildTelemetry()
                 .StartActivity("Build")?
                 .WithTags(_buildTelemetry)
                 .WithTags(_telemetryConsumingLogger?.WorkerNodeTelemetryData.AsActivityDataHolder(
-                    includeTasksDetails: !Traits.ExcludeTasksDetailsFromTelemetry
+                    includeTasksDetails: !Traits.ExcludeTasksDetailsFromTelemetry,
                     includeTargetDetails: false
                 ))
                 .WithStartTime(_buildTelemetry!.InnerStartAt)
diff --git a/src/Framework/Traits.cs b/src/Framework/Traits.cs
@@ -144,7 +144,7 @@ public Traits()
         public bool ExcludeTasksDetailsFromTelemetry = IsEnvVarOneOrTrue("MSBUILDTELEMETRYEXCLUDETASKSDETAILS");
 
         // for VS17.14
-        public readonly bool TelemetryOptIn = Environment.GetEnvironmentVariable("MSBUILD_TELEMETRY_OPTIN") == "1";
+        public readonly bool TelemetryOptIn = IsEnvVarOneOrTrue("MSBUILD_TELEMETRY_OPTIN");
 
         public static void UpdateFromEnvironment()
         {

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ public Traits()`
`144`	`144`	`public bool ExcludeTasksDetailsFromTelemetry = IsEnvVarOneOrTrue("MSBUILDTELEMETRYEXCLUDETASKSDETAILS");`
`145`	`145`
`146`	`146`	`// for VS17.14`
`147`		`- public readonly bool TelemetryOptIn = Environment.GetEnvironmentVariable("MSBUILD_TELEMETRY_OPTIN") == "1";`
	`147`	`+ public readonly bool TelemetryOptIn = IsEnvVarOneOrTrue("MSBUILD_TELEMETRY_OPTIN");`
`148`	`148`
`149`	`149`	`public static void UpdateFromEnvironment()`
`150`	`150`	`{`