Skip to content

Commit 488a8a3

Browse files
radicalLoopedBard3
andauthored
[release/8.0][wasm] Fix perf pipeline runs (#93888)
* Remove --experimental-wasm-eh argument from the wasm_args used for wasm performance runs. (#93357) (cherry picked from commit a770017) * performance-setup.sh: Use `release/8.0` as the default channel * performance-setup.ps1: use release/8.0 as the default channel * Fix passing wasmArgs for bdn --------- Co-authored-by: Parker Bibus <parkerbibus@microsoft.com>
1 parent 140a8ea commit 488a8a3

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

eng/testing/performance/performance-setup.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ if ($iOSNativeAOT) {
101101
}
102102

103103
# FIX ME: This is a workaround until we get this from the actual pipeline
104-
$CleanedBranchName = "main"
104+
$CleanedBranchName = "release/8.0"
105105
if($Branch.Contains("refs/heads/release"))
106106
{
107107
$CleanedBranchName = $Branch.replace('refs/heads/', '')

eng/testing/performance/performance-setup.sh

+3-6
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,7 @@ if [[ "$physicalpromotion" == "true" ]]; then
358358
configurations="$configurations PhysicalPromotionType=physicalpromotion"
359359
fi
360360

361-
362-
363-
cleaned_branch_name="main"
361+
cleaned_branch_name="release/8.0"
364362
if [[ $branch == *"refs/heads/release"* ]]; then
365363
cleaned_branch_name=${branch/refs\/heads\//}
366364
fi
@@ -404,15 +402,14 @@ if [[ -n "$wasm_bundle_directory" ]]; then
404402
using_wasm=true
405403
wasm_bundle_directory_path=$payload_directory
406404
mv $wasm_bundle_directory/* $wasm_bundle_directory_path
407-
find $wasm_bundle_directory_path -type d
408-
wasm_args="--experimental-wasm-eh --expose_wasm"
405+
wasm_args="--expose_wasm"
409406
if [ "$javascript_engine" == "v8" ]; then
410407
# for es6 module support
411408
wasm_args="$wasm_args --module"
412409
fi
413410

414411
# Workaround: escaping the quotes around `--wasmArgs=..` so they get retained for the actual command line
415-
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/bin/$javascript_engine --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
412+
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/bin/$javascript_engine \\\"--wasmArgs=$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
416413
if [[ "$wasmaot" == "true" ]]; then
417414
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --aotcompilermode wasm --buildTimeout 3600"
418415
fi

0 commit comments

Comments
 (0)