Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] method calls inside try/finally blocks are expensive #50783

Closed
jeromelaban opened this issue Apr 6, 2021 · 3 comments
Closed

[wasm][aot] method calls inside try/finally blocks are expensive #50783

jeromelaban opened this issue Apr 6, 2021 · 3 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Milestone

Comments

@jeromelaban
Copy link
Contributor

Description

Given:

[MethodImpl(MethodImplOptions.NoInlining)]
static void MyWorkload() { }

void TryMethod() { 
  try { 
    EmptyMethod(); 
    EmptyMethod();
  }
  finally { }
}

void DirectMethod() { 
  EmptyMethod(); 
  EmptyMethod();
}

TryMethod executes about slower around 5x in FF and 6.5x in Chrome than DirectMethod.

This issue is a migration of mono/mono#13653.

Configuration

b7a1648

Regression?

No

Other information

@dotnet-issue-labeler dotnet-issue-labeler bot added area-VM-meta-mono untriaged New issue has not been triaged by the area owner labels Apr 6, 2021
@ghost
Copy link

ghost commented Apr 6, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Given:

[MethodImpl(MethodImplOptions.NoInlining)]
static void MyWorkload() { }

void TryMethod() { 
  try { 
    EmptyMethod(); 
    EmptyMethod();
  }
  finally { }
}

void DirectMethod() { 
  EmptyMethod(); 
  EmptyMethod();
}

TryMethod executes about slower around 5x in FF and 6.5x in Chrome than DirectMethod.

This issue is a migration of mono/mono#13653.

Configuration

b7a1648

Regression?

No

Other information

Author: jeromelaban
Assignees: -
Labels:

area-VM-meta-mono, untriaged

Milestone: -

@ghost
Copy link

ghost commented Apr 6, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Given:

[MethodImpl(MethodImplOptions.NoInlining)]
static void MyWorkload() { }

void TryMethod() { 
  try { 
    EmptyMethod(); 
    EmptyMethod();
  }
  finally { }
}

void DirectMethod() { 
  EmptyMethod(); 
  EmptyMethod();
}

TryMethod executes about slower around 5x in FF and 6.5x in Chrome than DirectMethod.

This issue is a migration of mono/mono#13653.

Configuration

b7a1648

Regression?

No

Other information

Author: jeromelaban
Assignees: -
Labels:

arch-wasm, area-Codegen-AOT-mono, untriaged

Milestone: -

@vargaz
Copy link
Contributor

vargaz commented Jul 29, 2021

Same as
#56309

@vargaz vargaz closed this as completed Jul 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Projects
None yet
Development

No branches or pull requests

4 participants