-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0.1 hosting bundle no longer allows net8.0-windows #37892
Comments
perhaps this should be a discussion?? since i dont really know if it is a bug, or i am just "holding it wrong" |
working on a repro. but i need to find the correct combo of moving pieces |
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsOur projects target
After updating to sdk 8.0.101 and rebuilding our apps no longer run:
note that When building from 8.0.100 sdk we used to be able to run with only the hosting bundle installed if i change to changing
and our apps start running again dotnet -- info
runtimeconfig.jsonand when i look the same runtimeconfig.json between the sdks the 8.0.1 has indeed added from 8.0.100 sdk
from 8.0.101 sdk
Questions
|
Going to move this to dotnet/sdk since that's where the logic to generate the |
@SimonCropp what's a good repro for this behavior? Is a new console app targeting |
I think I found a minimal reproduction, it looks like it is because of <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0-windows</TargetFramework>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Data.SqlClient" Version="5.1.4" />
</ItemGroup>
</Project> This will include the {
"runtimeOptions": {
"tfm": "net8.0",
"frameworks": [
{
"name": "Microsoft.NETCore.App",
"version": "8.0.0"
},
{
"name": "Microsoft.WindowsDesktop.App",
"version": "8.0.0"
}
],
"configProperties": {
"System.Reflection.Metadata.MetadataUpdater.IsSupported": false,
"System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false
}
}
} Do a |
@campersau I'm having a hard time reproducing. For this project: <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0-windows</TargetFramework>
<RootNamespace>sdk_37892</RootNamespace>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Data.SqlClient" Version="5.1.4" />
</ItemGroup>
</Project> when I publish I get the following runtimeconfig.json: {
"runtimeOptions": {
"tfm": "net8.0",
"framework": {
"name": "Microsoft.NETCore.App",
"version": "8.0.0"
},
"configProperties": {
"System.Reflection.Metadata.MetadataUpdater.IsSupported": false,
"System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false
}
}
} without the WindowsDesktop framework. I'll try again with the 5.1.3 to 5.1.4 transition and see if I can get it to trigger. EDIT: Nevermind, I did get it to trigger. The offending dependency is "Microsoft.Identity.Client/4.56.0": {
"type": "package",
"dependencies": {
"Microsoft.Identity.Client.NativeInterop": "0.13.8",
"Microsoft.IdentityModel.Abstractions": "6.22.0",
"Microsoft.Web.WebView2": "1.0.864.35"
},
"compile": {
"lib/net6.0-windows7.0/Microsoft.Identity.Client.dll": {
"related": ".xml"
}
},
"runtime": {
"lib/net6.0-windows7.0/Microsoft.Identity.Client.dll": {
"related": ".xml"
}
},
"frameworkReferences": [
"Microsoft.WindowsDesktop.App.WindowsForms"
]
}, |
We need to reach out to the IdentityClient folks to see if this is an absolute requirement. Their repository is |
Looks like there is already an issue for it: AzureAD/microsoft-authentication-library-for-dotnet#4468 |
In the interim, I think I'm curious why the behavior seemingly changed between 8.0.100 and 8.0.101 - @SimonCropp are you sure that there were no other package version changes as part of your update? |
@baronfel sorry you are correct. we also update the sql nuget when doing the sdk change. so i have my wires crossed do u want to close this one? or rename it? |
I think we should close it for now - though we on the SDK team will try to reach out to the identity folks to determine a way to use the library that doesn't silently introduce new runtimes. |
ok will close. but is this effectively the cause of the bug dotnet/SqlClient#1108 (comment) ? |
That seems correct, looks like the team has a POC for removing some of the dependencies that may fix the issue? |
@baronfel is there a url for that discussion? |
This bit me and it's a pain. I can't believe our website deployment that uses SqlServer is down because This title seems accurate and unthinkable at the same time. "8.0.1 hosting bundle no longer allows net8.0-windows" It's hard to understand how such a bug could be released. That it was released clearly shows the limits of unit testing. And the bug still is not fixed after being identified 3.5 months ago. (sigh) Is this the best place to see the current status? AzureAD/microsoft-authentication-library-for-dotnet#4468 Are their other places one can get a status update? |
@rclabo here is the underlying issue and best place to discuss dotnet/SqlClient#1108 |
Our projects target
net8.0-windows
After updating to sdk 8.0.101 and rebuilding our apps no longer run:
note that
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.WindowsDesktop.App&framework_version=8.0.0&arch=x64&rid=win-x64&os=win10
redirects to
https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/runtime-desktop-8.0.1-windows-x64-installer?cid=getdotnetcore
When building from 8.0.100 sdk we used to be able to run with only the hosting bundle installed
https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/runtime-aspnetcore-8.0.1-windows-hosting-bundle-installer
ie no Desktop Runtime required
if i change to changing
net8
and our apps start running again
dotnet -- info
runtimeconfig.json
and when i look the same runtimeconfig.json between the sdks the 8.0.1 has indeed added
Microsoft.WindowsDesktop.App
from 8.0.100 sdk
from 8.0.101 sdk
Questions
The text was updated successfully, but these errors were encountered: