Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back HttpRequest.LogonUserIdentity #525

Closed
TaoziZ03 opened this issue Jul 30, 2024 · 0 comments · Fixed by #528
Closed

Add back HttpRequest.LogonUserIdentity #525

TaoziZ03 opened this issue Jul 30, 2024 · 0 comments · Fixed by #528
Labels
In-PR Issues that have a PR open for them. Needs: Triage 🔍 Label added to new issues which need Triage

Comments

@TaoziZ03
Copy link

Summary

HttpRequest.LogonUserIdentity was removed few days ago in #510. But it is being actively used in our codebase. Please add it back.

Motivation and goals

1-2 paragraphs, or a bullet-pointed list. What existing pain points does this solve? What evidence shows it's valuable to solve this?

In scope

A list of major scenarios, perhaps in priority order.

Out of scope

Scenarios you explicitly want to exclude.

Risks / unknowns

How might developers misinterpret/misuse this? How might implementing it restrict us from other enhancements in the future? Also list any perf/security/correctness concerns.

Examples

switch (context.Request.LogonUserIdentity.AuthenticationType.ToUpper(CultureInfo.InvariantCulture))
{
......
}
IntPtr userToken = context.Request.LogonUserIdentity.Token
@dotnet-policy-service dotnet-policy-service bot added the Needs: Triage 🔍 Label added to new issues which need Triage label Jul 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the In-PR Issues that have a PR open for them. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Issues that have a PR open for them. Needs: Triage 🔍 Label added to new issues which need Triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant