Skip to content

Commit 4137e50

Browse files
bebarinocjb
authored andcommitted
mmc: core: Fixup delayed work clock gating patch
c31b50e (mmc: core: Use delayed work in clock gating framework, 2011-11-14) missed a few things during review: o A useless pr_info() o milliseconds was written as two words o The sysfs file had units in its output Fix all three problems. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Cc: Sujit Reddy Thumma <sthumma@codeaurora.org> Signed-off-by: Chris Ball <cjb@laptop.org>
1 parent b678b91 commit 4137e50

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

Documentation/mmc/mmc-dev-attrs.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ SD/MMC/SDIO Clock Gating Attribute
7171
Read and write access is provided to following attribute.
7272
This attribute appears only if CONFIG_MMC_CLKGATE is enabled.
7373

74-
clkgate_delay Tune the clock gating delay with desired value in milli seconds.
74+
clkgate_delay Tune the clock gating delay with desired value in milliseconds.
7575

7676
echo <desired delay> > /sys/class/mmc_host/mmcX/clkgate_delay

drivers/mmc/core/host.c

+1-5
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ static ssize_t clkgate_delay_show(struct device *dev,
5858
struct device_attribute *attr, char *buf)
5959
{
6060
struct mmc_host *host = cls_dev_to_mmc_host(dev);
61-
return snprintf(buf, PAGE_SIZE, "%lu millisecs\n",
62-
host->clkgate_delay);
61+
return snprintf(buf, PAGE_SIZE, "%lu\n", host->clkgate_delay);
6362
}
6463

6564
static ssize_t clkgate_delay_store(struct device *dev,
@@ -74,9 +73,6 @@ static ssize_t clkgate_delay_store(struct device *dev,
7473
spin_lock_irqsave(&host->clk_lock, flags);
7574
host->clkgate_delay = value;
7675
spin_unlock_irqrestore(&host->clk_lock, flags);
77-
78-
pr_info("%s: clock gate delay set to %lu ms\n",
79-
mmc_hostname(host), value);
8076
return count;
8177
}
8278

0 commit comments

Comments
 (0)