Skip to content

Commit a91a5ac

Browse files
htejunaxboe
authored andcommitted
mempool: add @gfp_mask to mempool_create_node()
mempool_create_node() currently assumes %GFP_KERNEL. Its only user, blk_init_free_list(), is about to be updated to use other allocation flags - add @gfp_mask argument to the function. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Hugh Dickins <hughd@google.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 1597499 commit a91a5ac

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

block/blk-core.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,8 @@ static int blk_init_free_list(struct request_queue *q)
531531
init_waitqueue_head(&rl->wait[BLK_RW_ASYNC]);
532532

533533
rl->rq_pool = mempool_create_node(BLKDEV_MIN_RQ, mempool_alloc_slab,
534-
mempool_free_slab, request_cachep, q->node);
535-
534+
mempool_free_slab, request_cachep,
535+
GFP_KERNEL, q->node);
536536
if (!rl->rq_pool)
537537
return -ENOMEM;
538538

include/linux/mempool.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ typedef struct mempool_s {
2626
extern mempool_t *mempool_create(int min_nr, mempool_alloc_t *alloc_fn,
2727
mempool_free_t *free_fn, void *pool_data);
2828
extern mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn,
29-
mempool_free_t *free_fn, void *pool_data, int nid);
29+
mempool_free_t *free_fn, void *pool_data,
30+
gfp_t gfp_mask, int nid);
3031

3132
extern int mempool_resize(mempool_t *pool, int new_min_nr, gfp_t gfp_mask);
3233
extern void mempool_destroy(mempool_t *pool);

mm/mempool.c

+7-5
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,21 @@ EXPORT_SYMBOL(mempool_destroy);
6363
mempool_t *mempool_create(int min_nr, mempool_alloc_t *alloc_fn,
6464
mempool_free_t *free_fn, void *pool_data)
6565
{
66-
return mempool_create_node(min_nr,alloc_fn,free_fn, pool_data,-1);
66+
return mempool_create_node(min_nr,alloc_fn,free_fn, pool_data,
67+
GFP_KERNEL, NUMA_NO_NODE);
6768
}
6869
EXPORT_SYMBOL(mempool_create);
6970

7071
mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn,
71-
mempool_free_t *free_fn, void *pool_data, int node_id)
72+
mempool_free_t *free_fn, void *pool_data,
73+
gfp_t gfp_mask, int node_id)
7274
{
7375
mempool_t *pool;
74-
pool = kmalloc_node(sizeof(*pool), GFP_KERNEL | __GFP_ZERO, node_id);
76+
pool = kmalloc_node(sizeof(*pool), gfp_mask | __GFP_ZERO, node_id);
7577
if (!pool)
7678
return NULL;
7779
pool->elements = kmalloc_node(min_nr * sizeof(void *),
78-
GFP_KERNEL, node_id);
80+
gfp_mask, node_id);
7981
if (!pool->elements) {
8082
kfree(pool);
8183
return NULL;
@@ -93,7 +95,7 @@ mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn,
9395
while (pool->curr_nr < pool->min_nr) {
9496
void *element;
9597

96-
element = pool->alloc(GFP_KERNEL, pool->pool_data);
98+
element = pool->alloc(gfp_mask, pool->pool_data);
9799
if (unlikely(!element)) {
98100
mempool_destroy(pool);
99101
return NULL;

0 commit comments

Comments
 (0)