Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon by default changes UI scaling #1

Closed
strayge opened this issue May 28, 2023 · 2 comments
Closed

Addon by default changes UI scaling #1

strayge opened this issue May 28, 2023 · 2 comments

Comments

@strayge
Copy link

strayge commented May 28, 2023

Just enabling addon changes scaling of file tree, activity bar, status bar, tab bar.

No addon settings specified.

Is there any option to disable UI changes until it explicitly turned on by user?

vscode version
Version: 1.79.0-insider (Universal)
Commit: 2dfb838f494f035099e999f0cd0eff5f1f488a30
Date: 2023-05-26T05:24:15.292Z
Electron: 22.5.3
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin x64 21.6.0

Expected behaviour

No style changes, until user explicitly enable options / set styles in settings.

Actual behaviour

Font size and some icons became smaller in the next areas:

  • file tree
  • activity bar
  • status bar
  • tab bar

Visual diff

After "Disable Apc extension" command

image

After "Enable Apc extension" command

image

Steps to reproduce

  1. Install addon
  2. Run "Enable Apc extension" command
  3. Restart vscode
@mon-jai
Copy link

mon-jai commented May 28, 2023

Agree that UI changes should be disabled by default.

Seems that they would be fixed by next release: iocave/customize-ui#156 (comment)

@strayge
Copy link
Author

strayge commented May 28, 2023

Partial fix for me: in modules/patch.js change

  1. all browser.getZoomFactor() to 1
  2. default size in activityBarConfig from 35 to 48

Now it close to original
image

But is still different from default styles:

  • lower spacing around tab names
  • bigger activity bar icons (with the same activity bar width)

P.S. I have "window.zoomLevel": -1 in my config, probably scaling issue mostly coerced by it.

@drcika drcika closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants