Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc-serialize used by eui48 dependency is deprecated #140

Closed
queria opened this issue Jul 31, 2023 · 1 comment · Fixed by #142
Closed

rustc-serialize used by eui48 dependency is deprecated #140

queria opened this issue Jul 31, 2023 · 1 comment · Fixed by #142

Comments

@queria
Copy link

queria commented Jul 31, 2023

rustc-serialize is deprecated, from https://github.com/rust-lang-deprecated/rustc-serialize:
NOTE: This crate is deprecated in favor of [serde](https://serde.rs/).

It results in anything using openstack crate producing:
warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
As also it could have security impact too https://rustsec.org/advisories/RUSTSEC-2022-0004

rustc-serialize comes into rust-openstack as dependency of eui48

├── openstack v0.5.0
│   ├── eui48 v1.1.0
│   │   ├── regex v1.9.0 (*)
│   │   ├── rustc-serialize v0.3.24
│   │   └── serde v1.0.168 (*)

eui48 = { version = "^1.0", features = ["disp_hexstring", "serde"] }

eui48 itself does not seems responsive about this issue for a while already

One possible alternative seems to be to switch from eui48 to macaddr e.g.: ewilken/hap-rs#80

@dtantsur
Copy link
Owner

dtantsur commented Aug 1, 2023

Thanks for the heads-up, will take a look once I have some spare time (PRs welcome of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants