Skip to content

Commit d370721

Browse files
committed
Write out explicit types in Into::into conversions
1 parent bfcd89f commit d370721

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

src/lib.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ impl TokenStream {
209209

210210
fn _new_fallback(inner: fallback::TokenStream) -> Self {
211211
TokenStream {
212-
inner: inner.into(),
212+
inner: imp::TokenStream::from(inner),
213213
_marker: MARKER,
214214
}
215215
}
@@ -257,15 +257,15 @@ impl FromStr for TokenStream {
257257
#[cfg_attr(docsrs, doc(cfg(feature = "proc-macro")))]
258258
impl From<proc_macro::TokenStream> for TokenStream {
259259
fn from(inner: proc_macro::TokenStream) -> Self {
260-
TokenStream::_new(inner.into())
260+
TokenStream::_new(imp::TokenStream::from(inner))
261261
}
262262
}
263263

264264
#[cfg(feature = "proc-macro")]
265265
#[cfg_attr(docsrs, doc(cfg(feature = "proc-macro")))]
266266
impl From<TokenStream> for proc_macro::TokenStream {
267267
fn from(inner: TokenStream) -> Self {
268-
inner.inner.into()
268+
proc_macro::TokenStream::from(inner.inner)
269269
}
270270
}
271271

@@ -405,7 +405,7 @@ impl Span {
405405

406406
fn _new_fallback(inner: fallback::Span) -> Self {
407407
Span {
408-
inner: inner.into(),
408+
inner: imp::Span::from(inner),
409409
_marker: MARKER,
410410
}
411411
}
@@ -709,7 +709,7 @@ impl Group {
709709

710710
fn _new_fallback(inner: fallback::Group) -> Self {
711711
Group {
712-
inner: inner.into(),
712+
inner: imp::Group::from(inner),
713713
}
714714
}
715715

@@ -1138,7 +1138,7 @@ impl Literal {
11381138

11391139
fn _new_fallback(inner: fallback::Literal) -> Self {
11401140
Literal {
1141-
inner: inner.into(),
1141+
inner: imp::Literal::from(inner),
11421142
_marker: MARKER,
11431143
}
11441144
}

src/wrapper.rs

+18-10
Original file line numberDiff line numberDiff line change
@@ -161,27 +161,29 @@ impl From<fallback::TokenStream> for TokenStream {
161161
// Assumes inside_proc_macro().
162162
fn into_compiler_token(token: TokenTree) -> proc_macro::TokenTree {
163163
match token {
164-
TokenTree::Group(tt) => tt.inner.unwrap_nightly().into(),
164+
TokenTree::Group(tt) => proc_macro::TokenTree::from(tt.inner.unwrap_nightly()),
165165
TokenTree::Punct(tt) => {
166166
let spacing = match tt.spacing() {
167167
Spacing::Joint => proc_macro::Spacing::Joint,
168168
Spacing::Alone => proc_macro::Spacing::Alone,
169169
};
170170
let mut punct = proc_macro::Punct::new(tt.as_char(), spacing);
171171
punct.set_span(tt.span().inner.unwrap_nightly());
172-
punct.into()
172+
proc_macro::TokenTree::from(punct)
173173
}
174-
TokenTree::Ident(tt) => tt.inner.unwrap_nightly().into(),
175-
TokenTree::Literal(tt) => tt.inner.unwrap_nightly().into(),
174+
TokenTree::Ident(tt) => proc_macro::TokenTree::from(tt.inner.unwrap_nightly()),
175+
TokenTree::Literal(tt) => proc_macro::TokenTree::from(tt.inner.unwrap_nightly()),
176176
}
177177
}
178178

179179
impl From<TokenTree> for TokenStream {
180180
fn from(token: TokenTree) -> Self {
181181
if inside_proc_macro() {
182-
TokenStream::Compiler(DeferredTokenStream::new(into_compiler_token(token).into()))
182+
TokenStream::Compiler(DeferredTokenStream::new(proc_macro::TokenStream::from(
183+
into_compiler_token(token),
184+
)))
183185
} else {
184-
TokenStream::Fallback(token.into())
186+
TokenStream::Fallback(fallback::TokenStream::from(token))
185187
}
186188
}
187189
}
@@ -336,18 +338,24 @@ impl Iterator for TokenTreeIter {
336338
TokenTreeIter::Fallback(iter) => return iter.next(),
337339
};
338340
Some(match token {
339-
proc_macro::TokenTree::Group(tt) => crate::Group::_new(Group::Compiler(tt)).into(),
341+
proc_macro::TokenTree::Group(tt) => {
342+
TokenTree::from(crate::Group::_new(Group::Compiler(tt)))
343+
}
340344
proc_macro::TokenTree::Punct(tt) => {
341345
let spacing = match tt.spacing() {
342346
proc_macro::Spacing::Joint => Spacing::Joint,
343347
proc_macro::Spacing::Alone => Spacing::Alone,
344348
};
345349
let mut o = Punct::new(tt.as_char(), spacing);
346350
o.set_span(crate::Span::_new(Span::Compiler(tt.span())));
347-
o.into()
351+
TokenTree::from(o)
352+
}
353+
proc_macro::TokenTree::Ident(s) => {
354+
TokenTree::from(crate::Ident::_new(Ident::Compiler(s)))
355+
}
356+
proc_macro::TokenTree::Literal(l) => {
357+
TokenTree::from(crate::Literal::_new(Literal::Compiler(l)))
348358
}
349-
proc_macro::TokenTree::Ident(s) => crate::Ident::_new(Ident::Compiler(s)).into(),
350-
proc_macro::TokenTree::Literal(l) => crate::Literal::_new(Literal::Compiler(l)).into(),
351359
})
352360
}
353361

0 commit comments

Comments
 (0)