Skip to content

Commit 2d10027

Browse files
Add compile and lint verifications before testing (#23224)
* add compile and lint verifications before testing
1 parent 51a833a commit 2d10027

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

.github/workflows/pr-check.yml

+12-4
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ env:
3030
jobs:
3131
pr-check:
3232
runs-on: ubuntu-22.04
33-
33+
defaults:
34+
run:
35+
working-directory: tests/e2e
3436
steps:
3537
- name: Git checkout
3638
uses: actions/checkout@v2
@@ -48,6 +50,15 @@ jobs:
4850
with:
4951
node-version: '16'
5052

53+
- name: Check compilation errors
54+
run: |
55+
npm ci
56+
npm run tsc
57+
58+
- name: Check lint errors
59+
run: |
60+
npm run lint
61+
5162
- name: Start minikube
5263
id: run-minikube
5364
uses: che-incubator/setup-minikube-action@next
@@ -92,8 +103,6 @@ jobs:
92103
93104
- name: Run Empty Workspace API test
94105
run: |
95-
cd tests/e2e
96-
npm ci
97106
export TS_PLATFORM=kubernetes &&
98107
export TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL=kubectl &&
99108
export TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=false &&
@@ -109,7 +118,6 @@ jobs:
109118
run: |
110119
# for saving disk space we can remove the assembly folder because it is legacy code
111120
rm -rf assembly
112-
cd tests/e2e
113121
docker build -t quay.io/eclipse/che-e2e:"${{ env.pr_number }}" -f build/dockerfiles/Dockerfile .
114122
115123
# we have already ran API test, built test image and do not need e2e test-code, remove for saving disk space

0 commit comments

Comments
 (0)