Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management-api DTO validation are not executed on v2 #3011

Closed
6 of 7 tasks
ndr-brt opened this issue May 15, 2023 · 2 comments · Fixed by #3229
Closed
6 of 7 tasks

Management-api DTO validation are not executed on v2 #3011

ndr-brt opened this issue May 15, 2023 · 2 comments · Fixed by #3229
Assignees
Labels
api Feature related to the (REST) api dataspace-protocol related to the dataspace protocol enhancement New feature or request
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented May 15, 2023

Feature Request

Passing to the JsonObject management-api endpoints, the Jakarta validation we used to validate the DTOs is not in place anymore, so we should invoke it explicitly once the incoming Dto is created.

Which Areas Would Be Affected?

management api

Why Is the Feature Desired?

validation

Solution Proposal

If possible, provide a (brief!) solution proposal.

Checklist

  • Asset
  • ContractDefinition
  • ContractAgreement
  • PolicyDefinition
  • ContractNegotiation
  • TransferProcess
  • QuerySpecDto
@ndr-brt ndr-brt added enhancement New feature or request api Feature related to the (REST) api dataspace-protocol related to the dataspace protocol labels May 15, 2023
@ndr-brt ndr-brt added this to the Milestone 10 milestone May 15, 2023
@jimmarino
Copy link
Contributor

Do we need this anymore after this release? I'd like to get the management API to do a single pass transformation from Json-Ld to types rather then the two-phase transformation it does now. In that event, I think we should just perform our own validation so it is consistent with the protocol error reporting.

@ndr-brt ndr-brt changed the title Run management-api DTO validation explicitly Management-api DTO validation are not executed on v2 May 15, 2023
@ndr-brt
Copy link
Member Author

ndr-brt commented May 15, 2023

Yes, that makes sense as well, the point is that currently there's no validation, this was an issue to describe the lack of validation, as soon as it will be in place again we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants