Skip to content

Commit b15f561

Browse files
vince-fugnittovince-fugnitto
committed
deps: upgrade msgpackr
The commit upgrades `msgpackr` to a version which fixes the infinite recursion error caused by a problematic DTO calling `toJSON` which references itself. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
1 parent 8831c9d commit b15f561

File tree

3 files changed

+53
-45
lines changed

3 files changed

+53
-45
lines changed

‎doc/Migration.md

+12-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ Please see the latest version (`master`) for the most up-to-date information. Pl
1111

1212
_msgpackr_:
1313

14-
If you're experiencing [`maximum callstack exceeded`](https://github.com/eclipse-theia/theia/issues/12499) errors you may need to downgrade the version of `msgpackr` pulled using a [yarn resolution](https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/).
14+
If you're experiencing [`maximum callstack exceeded`](https://github.com/eclipse-theia/theia/issues/12499) errors you may need to either use a newer version (ex: `^1.9.5`) or downgrade the version of `msgpackr` pulled using a [yarn resolution](https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/).
15+
16+
Versions known to be problematic are `>1.8.3 && <1.9.5`.
1517

1618
```
1719
rpc-message-encoder.ts:151 Uncaught (in promise) Error: Error during encoding: 'Maximum call stack size exceeded'
@@ -25,6 +27,12 @@ For the best results follow the version used and tested by the framework.
2527

2628
For example:
2729

30+
```json
31+
"resolutions": {
32+
"**/msgpackr": "1.9.5"
33+
}
34+
```
35+
2836
```json
2937
"resolutions": {
3038
"**/msgpackr": "1.8.3"
@@ -72,15 +80,15 @@ For 2., `@postConstruct` methods can be refactored into a sync and an async meth
7280
```diff
7381
-@postConstruct()
7482
-protected async init(): Promise<void> {
75-
- await longRunningOperation();
83+
- await longRunningOperation();
7684
-}
7785
+@postConstruct()
7886
+protected init(): void {
79-
+ this.doInit();
87+
+ this.doInit();
8088
+}
8189
+
8290
+protected async doInit(): Promise<void> {
83-
+ await longRunningOperation();
91+
+ await longRunningOperation();
8492
+}
8593
```
8694

‎packages/core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"lodash.debounce": "^4.0.8",
5656
"lodash.throttle": "^4.1.1",
5757
"markdown-it": "^12.3.2",
58-
"msgpackr": "^1.6.1",
58+
"msgpackr": "^1.9.5",
5959
"nsfw": "^2.2.4",
6060
"p-debounce": "^2.1.0",
6161
"perfect-scrollbar": "^1.3.0",

‎yarn.lock

+40-40
Original file line numberDiff line numberDiff line change
@@ -1091,35 +1091,35 @@
10911091
dependencies:
10921092
cross-spawn "^7.0.1"
10931093

1094-
"@msgpackr-extract/msgpackr-extract-darwin-arm64@3.0.0":
1095-
version "3.0.0"
1096-
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-darwin-arm64/-/msgpackr-extract-darwin-arm64-3.0.0.tgz#d31a238c943ffc34bab73ad6ce7a6466d65888ef"
1097-
integrity sha512-5qpnNHUyyEj9H3sm/4Um/bnx1lrQGhe8iqry/1d+cQYCRd/gzYA0YLeq0ezlk4hKx4vO+dsEsNyeowqRqslwQA==
1094+
"@msgpackr-extract/msgpackr-extract-darwin-arm64@3.0.2":
1095+
version "3.0.2"
1096+
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-darwin-arm64/-/msgpackr-extract-darwin-arm64-3.0.2.tgz#44d752c1a2dc113f15f781b7cc4f53a307e3fa38"
1097+
integrity sha512-9bfjwDxIDWmmOKusUcqdS4Rw+SETlp9Dy39Xui9BEGEk19dDwH0jhipwFzEff/pFg95NKymc6TOTbRKcWeRqyQ==
10981098

1099-
"@msgpackr-extract/msgpackr-extract-darwin-x64@3.0.0":
1100-
version "3.0.0"
1101-
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-darwin-x64/-/msgpackr-extract-darwin-x64-3.0.0.tgz#2f6fbbec3d3f0bbe9c6678c899f1c1a6e25ed980"
1102-
integrity sha512-ZphTFFd6SFweNAMKD+QJCrWpgkjf4qBuHltiMkKkD6FFrB3NOTRVmetAGTkJ57pa+s6J0yCH06LujWB9rZe94g==
1099+
"@msgpackr-extract/msgpackr-extract-darwin-x64@3.0.2":
1100+
version "3.0.2"
1101+
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-darwin-x64/-/msgpackr-extract-darwin-x64-3.0.2.tgz#f954f34355712212a8e06c465bc06c40852c6bb3"
1102+
integrity sha512-lwriRAHm1Yg4iDf23Oxm9n/t5Zpw1lVnxYU3HnJPTi2lJRkKTrps1KVgvL6m7WvmhYVt/FIsssWay+k45QHeuw==
11031103

1104-
"@msgpackr-extract/msgpackr-extract-linux-arm64@3.0.0":
1105-
version "3.0.0"
1106-
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-linux-arm64/-/msgpackr-extract-linux-arm64-3.0.0.tgz#19875441da50b9aa8f8e726eb097a4cead435a3f"
1107-
integrity sha512-NEX6hdSvP4BmVyegaIbrGxvHzHvTzzsPaxXCsUt0mbLbPpEftsvNwaEVKOowXnLoeuGeD4MaqSwL3BUK2elsUA==
1104+
"@msgpackr-extract/msgpackr-extract-linux-arm64@3.0.2":
1105+
version "3.0.2"
1106+
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-linux-arm64/-/msgpackr-extract-linux-arm64-3.0.2.tgz#45c63037f045c2b15c44f80f0393fa24f9655367"
1107+
integrity sha512-FU20Bo66/f7He9Fp9sP2zaJ1Q8L9uLPZQDub/WlUip78JlPeMbVL8546HbZfcW9LNciEXc8d+tThSJjSC+tmsg==
11081108

1109-
"@msgpackr-extract/msgpackr-extract-linux-arm@3.0.0":
1110-
version "3.0.0"
1111-
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-linux-arm/-/msgpackr-extract-linux-arm-3.0.0.tgz#3b855ac72cc16e89db2f72adf47ddc964c20a53d"
1112-
integrity sha512-ztKVV1dO/sSZyGse0PBCq3Pk1PkYjsA/dsEWE7lfrGoAK3i9HpS2o7XjGQ7V4va6nX+xPPOiuYpQwa4Bi6vlww==
1109+
"@msgpackr-extract/msgpackr-extract-linux-arm@3.0.2":
1110+
version "3.0.2"
1111+
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-linux-arm/-/msgpackr-extract-linux-arm-3.0.2.tgz#35707efeafe6d22b3f373caf9e8775e8920d1399"
1112+
integrity sha512-MOI9Dlfrpi2Cuc7i5dXdxPbFIgbDBGgKR5F2yWEa6FVEtSWncfVNKW5AKjImAQ6CZlBK9tympdsZJ2xThBiWWA==
11131113

1114-
"@msgpackr-extract/msgpackr-extract-linux-x64@3.0.0":
1115-
version "3.0.0"
1116-
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-linux-x64/-/msgpackr-extract-linux-x64-3.0.0.tgz#455f1d5bb00e87f78c67711f26e7bff9f1457684"
1117-
integrity sha512-9uvdAkZMOPCY7SPRxZLW8XGqBOVNVEhqlgffenN8shA1XR9FWVsSM13nr/oHtNgXg6iVyML7RwWPyqUeThlwxg==
1114+
"@msgpackr-extract/msgpackr-extract-linux-x64@3.0.2":
1115+
version "3.0.2"
1116+
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-linux-x64/-/msgpackr-extract-linux-x64-3.0.2.tgz#091b1218b66c341f532611477ef89e83f25fae4f"
1117+
integrity sha512-gsWNDCklNy7Ajk0vBBf9jEx04RUxuDQfBse918Ww+Qb9HCPoGzS+XJTLe96iN3BVK7grnLiYghP/M4L8VsaHeA==
11181118

1119-
"@msgpackr-extract/msgpackr-extract-win32-x64@3.0.0":
1120-
version "3.0.0"
1121-
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-win32-x64/-/msgpackr-extract-win32-x64-3.0.0.tgz#03c6bfcd3acb179ea69546c20d50895b9d623ada"
1122-
integrity sha512-Wg0+9615kHKlr9iLVcG5I+/CHnf6w3x5UADRv8Ad16yA0Bu5l9eVOROjV7aHPG6uC8ZPFIVVaoSjDChD+Y0pzg==
1119+
"@msgpackr-extract/msgpackr-extract-win32-x64@3.0.2":
1120+
version "3.0.2"
1121+
resolved "https://registry.yarnpkg.com/@msgpackr-extract/msgpackr-extract-win32-x64/-/msgpackr-extract-win32-x64-3.0.2.tgz#0f164b726869f71da3c594171df5ebc1c4b0a407"
1122+
integrity sha512-O+6Gs8UeDbyFpbSh2CPEz/UOrrdWPTBYNblZK5CxxLisYt4kGX3Sc+czffFonyjiGSq3jWLwJS/CCJc7tBr4sQ==
11231123

11241124
"@nodelib/fs.scandir@2.1.5":
11251125
version "2.1.5"
@@ -7753,26 +7753,26 @@ ms@2.1.3, ms@^2.0.0, ms@^2.1.1:
77537753
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.3.tgz#574c8138ce1d2b5861f0b44579dbadd60c6615b2"
77547754
integrity sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==
77557755

7756-
msgpackr-extract@^3.0.0:
7757-
version "3.0.0"
7758-
resolved "https://registry.yarnpkg.com/msgpackr-extract/-/msgpackr-extract-3.0.0.tgz#5b5c5fbfff25be5ee5b5a82a9cbe02e37f72bed0"
7759-
integrity sha512-oy6KCk1+X4Bn5m6Ycq5N1EWl9npqG/cLrE8ga8NX7ZqfqYUUBS08beCQaGq80fjbKBySur0E6x//yZjzNJDt3A==
7756+
msgpackr-extract@^3.0.2:
7757+
version "3.0.2"
7758+
resolved "https://registry.yarnpkg.com/msgpackr-extract/-/msgpackr-extract-3.0.2.tgz#e05ec1bb4453ddf020551bcd5daaf0092a2c279d"
7759+
integrity sha512-SdzXp4kD/Qf8agZ9+iTu6eql0m3kWm1A2y1hkpTeVNENutaB0BwHlSvAIaMxwntmRUAUjon2V4L8Z/njd0Ct8A==
77607760
dependencies:
77617761
node-gyp-build-optional-packages "5.0.7"
77627762
optionalDependencies:
7763-
"@msgpackr-extract/msgpackr-extract-darwin-arm64" "3.0.0"
7764-
"@msgpackr-extract/msgpackr-extract-darwin-x64" "3.0.0"
7765-
"@msgpackr-extract/msgpackr-extract-linux-arm" "3.0.0"
7766-
"@msgpackr-extract/msgpackr-extract-linux-arm64" "3.0.0"
7767-
"@msgpackr-extract/msgpackr-extract-linux-x64" "3.0.0"
7768-
"@msgpackr-extract/msgpackr-extract-win32-x64" "3.0.0"
7769-
7770-
msgpackr@^1.6.1:
7771-
version "1.8.3"
7772-
resolved "https://registry.yarnpkg.com/msgpackr/-/msgpackr-1.8.3.tgz#78c1b91359f72707f4abeaca40cc423bd2d75185"
7773-
integrity sha512-m2JefwcKNzoHYXkH/5jzHRxAw7XLWsAdvu0FOJ+OLwwozwOV/J6UA62iLkfIMbg7G8+dIuRwgg6oz+QoQ4YkoA==
7763+
"@msgpackr-extract/msgpackr-extract-darwin-arm64" "3.0.2"
7764+
"@msgpackr-extract/msgpackr-extract-darwin-x64" "3.0.2"
7765+
"@msgpackr-extract/msgpackr-extract-linux-arm" "3.0.2"
7766+
"@msgpackr-extract/msgpackr-extract-linux-arm64" "3.0.2"
7767+
"@msgpackr-extract/msgpackr-extract-linux-x64" "3.0.2"
7768+
"@msgpackr-extract/msgpackr-extract-win32-x64" "3.0.2"
7769+
7770+
msgpackr@^1.9.5:
7771+
version "1.9.5"
7772+
resolved "https://registry.yarnpkg.com/msgpackr/-/msgpackr-1.9.5.tgz#ac548c5f4546db895e84e46d39d813be961dc527"
7773+
integrity sha512-/IJ3cFSN6Ci3eG2wLhbFEL6GT63yEaoN/R5My2QkV6zro+OJaVRLPlwvxY7EtHYSmDlQpk8stvOQTL2qJFkDRg==
77747774
optionalDependencies:
7775-
msgpackr-extract "^3.0.0"
7775+
msgpackr-extract "^3.0.2"
77767776

77777777
multer@1.4.4-lts.1:
77787778
version "1.4.4-lts.1"

0 commit comments

Comments
 (0)