Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybinding Context Broken #819

Closed
svenefftinge opened this issue Nov 10, 2017 · 1 comment
Closed

Keybinding Context Broken #819

svenefftinge opened this issue Nov 10, 2017 · 1 comment
Labels
keybindings issues related to keybindings

Comments

@svenefftinge
Copy link
Contributor

Filtering the right keybinding for a keycode and for command, currently ignores the context, but picks the first (active).

It should first check the context and then whether there is an enabled handler.
@svenefftinge svenefftinge added the keybindings issues related to keybindings label Nov 10, 2017
@svenefftinge svenefftinge mentioned this issue Nov 10, 2017
Closed
@hexa00
Copy link

hexa00 commented Feb 12, 2018

This is not entirely true anymore, sortKeybindingsByPriority gives priority to a keybinding with a context and tryKeybindingExecution checks if that context is active.

More code could be moved however from tryKeybindingExecution to getKeybindingsForKeySequence so that it returns only the enabled keybindings...

But I'm not sure it's useful.

@svenefftinge ok to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenefftinge @hexa00