Recent vscode/git fail to run

[jeluard]

With latest theia (1.11), recent versions of vscode/git fail with the following error:

root ERROR [hosted-plugin: 47065] Activating extension 'Git (built-in)' failed: TypeError: n.window.registerFileDecorationProvider is not a function
    at new c (/Users/julien/theia/plugins/vscode-builtin-git/extension/dist/main.js:10:470092)
    at new t.GitDecorations (/Users/julien/theia/plugins/vscode-builtin-git/extension/dist/main.js:10:472492)
    at C (/Users/julien/theia/plugins/vscode-builtin-git/extension/dist/main.js:1:104831)

It appears that some VSCode API has been renamed: microsoft/vscode@d04f317

[azatsarynnyy]

Hello @jeluard,
could you file a Theia issue for updating window.registerDecorationProvider -> window.registerFileDecorationProvider.
It seems we need to just update it here
https://github.com/eclipse-theia/theia/blob/master/packages/plugin/src/theia-proposed.d.ts#L286
BTW, it would be a good issue as for the first contribution 😉

[jeluard]

I'll take a look! Should the older name (registerDecorationProvider ) still be available?

[azatsarynnyy]

I'll take a look! Should the older name (registerDecorationProvider ) still be available?

I don't think so.

[vince-fugnitto]

For the Eclipse Theia framework I believe it is already handled by the following pull-request:

• Apply FileDecoration provider API theia#8911

[jeluard]

@vince-fugnitto Good catch! I'll wait for the merge then!

[vince-fugnitto]

Closing as the issue is related to the theia framework (fixed as part of eclipse-theia/theia#8911), and not the publishing of builtins.