pr remarks

Author: wolf4ood

charts/tractusx-connector-memory/example.yaml

@@ -34,7 +34,7 @@
 fullnameOverride: tx-inmem
 
 participant:
-  id: "test"
+  id: "test-participant"
 
 runtime:
   service:

docs/migration/Version_0.3.4_0.4.0.md

@@ -1,4 +1,4 @@
-# Migration from 0.3.3 to 0.4.0
+# Migration from 0.3.4 to 0.4.0
 
 ## Switching to DSP
 

edc-extensions/cx-oauth2/src/main/java/org/eclipse/tractusx/edc/oauth2/CxParticipantExtension.java

@@ -36,13 +36,13 @@ public class CxParticipantExtension implements ServiceExtension, ParticipantAgen
     private static final String DEFAULT_PARTICIPANT_ID_REGEX = "[^/]+(?=/$|$)";
     private static final int DEFAULT_PARTICIPANT_ID_REGEX_GROUP = 0;
 
-    @Setting(value = "Data plane proxy API consumer port", defaultValue = CxParticipantExtension.PARTICIPANT_ID_REGEX)
+    @Setting(value = "Participant Extractor from referringConnector regex", defaultValue = CxParticipantExtension.DEFAULT_PARTICIPANT_ID_REGEX)
     private static final String PARTICIPANT_ID_REGEX = "tx.participant.id.regex";
 
-    @Setting(value = "Data plane proxy API consumer port", defaultValue = CxParticipantExtension.PARTICIPANT_ID_REGEX)
-    private static final String PARTICIPANT_ID_REGEX_GROUP = "tx.participant.id.regex";
+    @Setting(value = "Participant Extractor from referringConnector regex group", defaultValue = "0")
+    private static final String PARTICIPANT_ID_REGEX_GROUP = "tx.participant.id.regexGroup";
     @Inject
-    ParticipantAgentService agentService;
+    private ParticipantAgentService agentService;
     private Pattern participantRegex;
 
     private int participantRegexGroup;

edc-extensions/hashicorp-vault/src/main/java/org/eclipse/tractusx/edc/hashicorpvault/AbstractHashicorpVaultExtension.java

@@ -51,7 +51,7 @@ public class AbstractHashicorpVaultExtension {
 
     private static final String VAULT_TIMEOUT_SECONDS = "edc.vault.hashicorp.timeout.seconds";
 
-    public HashicorpVaultClient createVaultClient(ServiceExtensionContext context, ObjectMapper mapper) {
+    protected HashicorpVaultClient createVaultClient(ServiceExtensionContext context, ObjectMapper mapper) {
         var config = loadHashicorpVaultClientConfig(context);
 
         var okHttpClient = createOkHttpClient(config);

edc-extensions/hashicorp-vault/src/main/java/org/eclipse/tractusx/edc/hashicorpvault/HashicorpVaultHealthExtension.java

@@ -57,11 +57,11 @@ public void initialize(ServiceExtensionContext context) {
     }
 
     private void configureHealthCheck(HashicorpVaultClient client, ServiceExtensionContext context) {
-        final boolean healthCheckEnabled =
+        var healthCheckEnabled =
                 context.getSetting(VAULT_HEALTH_CHECK, VAULT_HEALTH_CHECK_DEFAULT);
         if (!healthCheckEnabled) return;
 
-        final HashicorpVaultHealthCheck healthCheck =
+        var healthCheck =
                 new HashicorpVaultHealthCheck(client, context.getMonitor());
 
         healthCheckService.addLivenessProvider(healthCheck);

edc-extensions/hashicorp-vault/src/main/java/org/eclipse/tractusx/edc/hashicorpvault/HashicorpVaultVaultExtension.java

@@ -30,7 +30,7 @@
 import org.eclipse.edc.spi.system.ServiceExtensionContext;
 import org.eclipse.edc.spi.types.TypeManager;
 
-@Provides({ Vault.class, CertificateResolver.class, PrivateKeyResolver.class })
+@Provides({Vault.class, CertificateResolver.class, PrivateKeyResolver.class})
 public class HashicorpVaultVaultExtension extends AbstractHashicorpVaultExtension
         implements ServiceExtension {
 
@@ -46,10 +46,10 @@ public String name() {
     public void initialize(ServiceExtensionContext context) {
         var client = createVaultClient(context, typeManager.getMapper());
 
-        final HashicorpVault vault = new HashicorpVault(client);
-        final CertificateResolver certificateResolver =
+        var vault = new HashicorpVault(client);
+        var certificateResolver =
                 new HashicorpCertificateResolver(vault, context.getMonitor());
-        final VaultPrivateKeyResolver privateKeyResolver = new VaultPrivateKeyResolver(vault);
+        var privateKeyResolver = new VaultPrivateKeyResolver(vault);
 
         context.registerService(Vault.class, vault);
         context.registerService(CertificateResolver.class, certificateResolver);

edc-tests/deployment/src/main/resources/helm/tractusx-connector-azure-vault-test.yaml

@@ -39,7 +39,7 @@ fullnameOverride: tx-prod
 # EDC ControlPlane + DataPlane #
 ################################
 participant:
-  id: "test"
+  id: "test-participant"
 
 controlplane:
   service:

edc-tests/deployment/src/main/resources/helm/tractusx-connector-test.yaml

@@ -24,7 +24,7 @@ fullnameOverride: tx-prod
 ################################
 
 participant:
-  id: "test"
+  id: "test-participant"
 
 controlplane:
   service: