Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 460f382

Browse files
authoredApr 20, 2023
chore: Add 0.3.3 to, and fix markdown in CHANGELOG.md (#252)
1 parent 52a3ecd commit 460f382

File tree

1 file changed

+163
-154
lines changed

1 file changed

+163
-154
lines changed
 

‎CHANGELOG.md

+163-154
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
## [0.3.3] - 2023-04-19
1111

12+
### Fixed
13+
14+
- Config values for the data plane part of the helm chart
15+
- Contract Validity
16+
17+
### Added
18+
19+
- A log line whenever a policy evaluation of the BPN number was performed
20+
1221
## [0.3.2] - 2023-03-30
1322

1423
### Fixed
1524

16-
- Fixed mutually-exclusive config values for Azure KeyVault
25+
- Fixed mutually-exclusive config values for Azure KeyVault
1726

1827
## [0.3.1] - 2023-03-27
1928

2029
### Added
2130

2231
### Changed
2332

24-
- Support unauthenticated access to the ObservabilityAPI (#126)
33+
- Support unauthenticated access to the ObservabilityAPI (#126)
2534

2635
### Fixed
2736

@@ -32,144 +41,144 @@ corresponding [documentation](/docs/migration/Version_0.1.x_0.3.x.md).
3241

3342
### Added
3443

35-
- Add contract id to data source http call (#732)
36-
- Support also support releases in ci pipeline
37-
- Introduce typed object for oauth2 provisioning
38-
- Add documentation
39-
- Add test case
40-
- Add client to omejdn
41-
- add hydra deployment
42-
- Configure dynamically HTTP Receiver callback endpoints. (#685)
43-
- cp-adapter : code review, rollbacke name change (#664)
44-
- Feature/cp adapter task 355 356 357 (#621)
45-
- Add Validity Mapping in ContractDefinitionStepDefs class
46-
- Add feature and create SendAnOfferwithoutConstraints method in class negotiationSteps
47-
- Add validity attribute in class ContractDefinition
48-
- Add Validity Mapping in ContractDefinitionStepDefs class
49-
- Add feature and create SendAnOfferwithoutConstraints method in class negotiationSteps
50-
- Add validity attribute in class ContractDefinition
51-
- Local TXDC Setup Documentation (#618)
52-
- Feature: Sftp Provisioner and Client (#554)
44+
- Add contract id to data source http call (#732)
45+
- Support also support releases in ci pipeline
46+
- Introduce typed object for oauth2 provisioning
47+
- Add documentation
48+
- Add test case
49+
- Add client to omejdn
50+
- add hydra deployment
51+
- Configure dynamically HTTP Receiver callback endpoints. (#685)
52+
- cp-adapter : code review, rollbacke name change (#664)
53+
- Feature/cp adapter task 355 356 357 (#621)
54+
- Add Validity Mapping in ContractDefinitionStepDefs class
55+
- Add feature and create SendAnOfferwithoutConstraints method in class negotiationSteps
56+
- Add validity attribute in class ContractDefinition
57+
- Add Validity Mapping in ContractDefinitionStepDefs class
58+
- Add feature and create SendAnOfferwithoutConstraints method in class negotiationSteps
59+
- Add validity attribute in class ContractDefinition
60+
- Local TXDC Setup Documentation (#618)
61+
- Feature: Sftp Provisioner and Client (#554)
5362

5463
### Changed
5564

56-
- Support horizontal edc scaling in cp adapter extension (#678)
57-
- Use upstream jackson version (#741)
58-
- Replace provision-oauth2 with data-plane-http-oauth2
59-
- docs: Update sample documentation (#671)
60-
- chore: Disable build ci pipeline if just docu was updated (#705)
61-
- Increase trivy timeout
62-
- Remove not useful anymore custom-jsonld extension (#683)
63-
- update setup docu (#654)
64-
- remove trailing slash (#652)
65-
- update alpine from 3.17.0 to 3.17.1 for controlplane-memory-hashicorp-vault (#665)
66-
- Feature/set charts deprecated (#628)
67-
- update setup docu (#627)
68-
- Feature/update txdc deployment downward capabilities (#625)
69-
- remove git submodule (#619)
70-
- Feature/update postman (#624)
71-
- update control plane docu (#623)
72-
- update postgresql version in Chart.yaml supporting-infrastructure (#622)
73-
- update link to edc logo in README.md (#612)
74-
- update description of supporting infrastructure deployment (#616)
65+
- Support horizontal edc scaling in cp adapter extension (#678)
66+
- Use upstream jackson version (#741)
67+
- Replace provision-oauth2 with data-plane-http-oauth2
68+
- docs: Update sample documentation (#671)
69+
- chore: Disable build ci pipeline if just docu was updated (#705)
70+
- Increase trivy timeout
71+
- Remove not useful anymore custom-jsonld extension (#683)
72+
- update setup docu (#654)
73+
- remove trailing slash (#652)
74+
- update alpine from 3.17.0 to 3.17.1 for controlplane-memory-hashicorp-vault (#665)
75+
- Feature/set charts deprecated (#628)
76+
- update setup docu (#627)
77+
- Feature/update txdc deployment downward capabilities (#625)
78+
- remove git submodule (#619)
79+
- Feature/update postman (#624)
80+
- update control plane docu (#623)
81+
- update postgresql version in Chart.yaml supporting-infrastructure (#622)
82+
- update link to edc logo in README.md (#612)
83+
- update description of supporting infrastructure deployment (#616)
7584

7685
### Fixed
7786

78-
- bugfix: Fix slow AES encryption (#746)
79-
- Fix typo in tractusx-connector values.yaml comment
80-
- Fix not working docu link in README.md
81-
- Fix typo in control-plane adapter README
87+
- bugfix: Fix slow AES encryption (#746)
88+
- Fix typo in tractusx-connector values.yaml comment
89+
- Fix not working docu link in README.md
90+
- Fix typo in control-plane adapter README
8291

8392
### Dependency updates
8493

85-
- Bump EDC to 20220220 (#767)
86-
- Bump alpine (#749)
87-
- Bump alpine (#750)
88-
- Bump alpine (#752)
89-
- Bump alpine in /edc-controlplane/edc-runtime-memory/src/main/docker (#753)
90-
- Bump maven-deploy-plugin from 3.0.0 to 3.1.0 (#735)
91-
- Bump actions/setup-java from 3.9.0 to 3.10.0 (#730)
92-
- Bump s3 from 2.19.33 to 2.20.0
93-
- Bump s3 from 2.19.27 to 2.19.33
94-
- Bump jaxb-runtime from 4.0.1 to 4.0.2
95-
- Bump spotless-maven-plugin from 2.31.0 to 2.32.0
96-
- Bump postgresql from 42.5.1 to 42.5.3
97-
- Bump nimbus-jose-jwt from 9.30 to 9.30.1
98-
- Bump lombok from 1.18.24 to 1.18.26
99-
- Bump flyway-core from 9.12.0 to 9.14.1
100-
- Bump jackson-bom from 2.14.0-rc2 to 2.14.2
101-
- Bump cucumber.version from 7.11.0 to 7.11.1
102-
- Bump azure-sdk-bom from 1.2.8 to 1.2.9
103-
- Bump mockito-bom from 5.0.0 to 5.1.1
104-
- Bump edc version to 0.0.1-20230131-SNAPSHOT
105-
- Bump s3 from 2.19.18 to 2.19.27
106-
- Bump docker/build-push-action from 3 to 4
107-
- Bump nimbus-jose-jwt from 9.29 to 9.30
108-
- Bump spotless-maven-plugin from 2.30.0 to 2.31.0
109-
- Bump nimbus-jose-jwt from 9.28 to 9.29
110-
- Bump mockito-bom from 4.11.0 to 5.0.0
111-
- Bump edc version to 0.0.1-20230125-SNAPSHOT
112-
- Bump flyway-core from 9.11.0 to 9.12.0
113-
- Bump s3 from 2.19.15 to 2.19.18 (#684)
114-
- Bump mikefarah/yq from 4.30.6 to 4.30.8 (#682)
115-
- Bump spotless-maven-plugin from 2.29.0 to 2.30.0
116-
- Bump edc version to 0.0.1-20230115-SNAPSHOT
117-
- Bump cucumber.version from 7.10.1 to 7.11.0 (#672)
118-
- Bump maven-dependency-plugin from 3.4.0 to 3.5.0 (#669)
119-
- Bump s3 from 2.19.11 to 2.19.15 (#668)
120-
- Bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8 (#670)
121-
- Bump edc version to 0.0.1-20230109-SNAPSHOT (#666)
122-
- Bump alpine in /edc-controlplane/edc-runtime-memory/src/main/docker (#659)
123-
- Bump alpine in /edc-dataplane/edc-dataplane-azure-vault/src/main/docker (#660)
124-
- Bump alpine (#658)
125-
- Bump alpine (#661)
126-
- Bump alpine (#662)
127-
- Bump azure/setup-kubectl from 3.1 to 3.2 (#655)
128-
- Bump junit-bom from 5.9.1 to 5.9.2 (#657)
129-
- Bump s3 from 2.19.2 to 2.19.11 (#648)
130-
- Bump actions/checkout from 3.2.0 to 3.3.0 (#647)
131-
- Bump flyway-core from 9.10.2 to 9.11.0 (#646)
132-
- Bump spotless-maven-plugin from 2.28.0 to 2.29.0 (#641)
133-
- Bump mockito-bom from 4.10.0 to 4.11.0 (#637)
134-
- Bump flyway-core from 9.10.1 to 9.10.2 (#632)
135-
- Bump s3 from 2.19.1 to 2.19.2 (#631)
136-
- Bump s3 from 2.18.41 to 2.19.1 (#626)
137-
- Bump mikefarah/yq from 4.30.5 to 4.30.6 (#613)
138-
- Bump cucumber.version from 7.10.0 to 7.10.1 (#614)
139-
- Bump s3 from 2.18.40 to 2.18.41 (#615)
140-
- Bump azure/setup-helm from 3.4 to 3.5 (#596)
141-
- Bump actions/checkout from 3.1.0 to 3.2.0 (#598)
142-
- Bump mockito-bom from 4.9.0 to 4.10.0 (#607)
143-
- Bump s3 from 2.18.39 to 2.18.40 (#609)
144-
- Bump flyway-core from 9.10.0 to 9.10.1 (#610)
145-
- Bump actions/setup-java from 3.8.0 to 3.9.0 (#605)
146-
- Bump s3 from 2.18.35 to 2.18.39 (#606)
94+
- Bump EDC to 20220220 (#767)
95+
- Bump alpine (#749)
96+
- Bump alpine (#750)
97+
- Bump alpine (#752)
98+
- Bump alpine in /edc-controlplane/edc-runtime-memory/src/main/docker (#753)
99+
- Bump maven-deploy-plugin from 3.0.0 to 3.1.0 (#735)
100+
- Bump actions/setup-java from 3.9.0 to 3.10.0 (#730)
101+
- Bump s3 from 2.19.33 to 2.20.0
102+
- Bump s3 from 2.19.27 to 2.19.33
103+
- Bump jaxb-runtime from 4.0.1 to 4.0.2
104+
- Bump spotless-maven-plugin from 2.31.0 to 2.32.0
105+
- Bump postgresql from 42.5.1 to 42.5.3
106+
- Bump nimbus-jose-jwt from 9.30 to 9.30.1
107+
- Bump lombok from 1.18.24 to 1.18.26
108+
- Bump flyway-core from 9.12.0 to 9.14.1
109+
- Bump jackson-bom from 2.14.0-rc2 to 2.14.2
110+
- Bump cucumber.version from 7.11.0 to 7.11.1
111+
- Bump azure-sdk-bom from 1.2.8 to 1.2.9
112+
- Bump mockito-bom from 5.0.0 to 5.1.1
113+
- Bump edc version to 0.0.1-20230131-SNAPSHOT
114+
- Bump s3 from 2.19.18 to 2.19.27
115+
- Bump docker/build-push-action from 3 to 4
116+
- Bump nimbus-jose-jwt from 9.29 to 9.30
117+
- Bump spotless-maven-plugin from 2.30.0 to 2.31.0
118+
- Bump nimbus-jose-jwt from 9.28 to 9.29
119+
- Bump mockito-bom from 4.11.0 to 5.0.0
120+
- Bump edc version to 0.0.1-20230125-SNAPSHOT
121+
- Bump flyway-core from 9.11.0 to 9.12.0
122+
- Bump s3 from 2.19.15 to 2.19.18 (#684)
123+
- Bump mikefarah/yq from 4.30.6 to 4.30.8 (#682)
124+
- Bump spotless-maven-plugin from 2.29.0 to 2.30.0
125+
- Bump edc version to 0.0.1-20230115-SNAPSHOT
126+
- Bump cucumber.version from 7.10.1 to 7.11.0 (#672)
127+
- Bump maven-dependency-plugin from 3.4.0 to 3.5.0 (#669)
128+
- Bump s3 from 2.19.11 to 2.19.15 (#668)
129+
- Bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8 (#670)
130+
- Bump edc version to 0.0.1-20230109-SNAPSHOT (#666)
131+
- Bump alpine in /edc-controlplane/edc-runtime-memory/src/main/docker (#659)
132+
- Bump alpine in /edc-dataplane/edc-dataplane-azure-vault/src/main/docker (#660)
133+
- Bump alpine (#658)
134+
- Bump alpine (#661)
135+
- Bump alpine (#662)
136+
- Bump azure/setup-kubectl from 3.1 to 3.2 (#655)
137+
- Bump junit-bom from 5.9.1 to 5.9.2 (#657)
138+
- Bump s3 from 2.19.2 to 2.19.11 (#648)
139+
- Bump actions/checkout from 3.2.0 to 3.3.0 (#647)
140+
- Bump flyway-core from 9.10.2 to 9.11.0 (#646)
141+
- Bump spotless-maven-plugin from 2.28.0 to 2.29.0 (#641)
142+
- Bump mockito-bom from 4.10.0 to 4.11.0 (#637)
143+
- Bump flyway-core from 9.10.1 to 9.10.2 (#632)
144+
- Bump s3 from 2.19.1 to 2.19.2 (#631)
145+
- Bump s3 from 2.18.41 to 2.19.1 (#626)
146+
- Bump mikefarah/yq from 4.30.5 to 4.30.6 (#613)
147+
- Bump cucumber.version from 7.10.0 to 7.10.1 (#614)
148+
- Bump s3 from 2.18.40 to 2.18.41 (#615)
149+
- Bump azure/setup-helm from 3.4 to 3.5 (#596)
150+
- Bump actions/checkout from 3.1.0 to 3.2.0 (#598)
151+
- Bump mockito-bom from 4.9.0 to 4.10.0 (#607)
152+
- Bump s3 from 2.18.39 to 2.18.40 (#609)
153+
- Bump flyway-core from 9.10.0 to 9.10.1 (#610)
154+
- Bump actions/setup-java from 3.8.0 to 3.9.0 (#605)
155+
- Bump s3 from 2.18.35 to 2.18.39 (#606)
147156

148157
## [0.1.6] - 2023-02-20
149158

150159
### Fixed
151160

152-
- SQL leakage issue
153-
- Catalog pagination
161+
- SQL leakage issue
162+
- Catalog pagination
154163

155164
## [0.1.5] - 2023-02-13
156165

157166
### Fixed
158167

159-
- Use patched EDC version: 0.0.1-20220922.2-SNAPSHOT to fix catalog pagination bug
160-
- Data Encryption extension: fixed usage of a blocking algorithm
168+
- Use patched EDC version: 0.0.1-20220922.2-SNAPSHOT to fix catalog pagination bug
169+
- Data Encryption extension: fixed usage of a blocking algorithm
161170

162171
## [0.1.2] - 2022-09-30
163172

164173
### Added
165174

166-
- Introduced DEPENDENCIES file
175+
- Introduced DEPENDENCIES file
167176

168177
### Changed
169178

170-
- Moved helm charts from `deployment/helm` to `charts`
171-
- Replaced distroless image with alpine in all docker images
172-
- Update EDC commit to `740c100ac162bc41b1968c232ad81f7d739aefa9`
179+
- Moved helm charts from `deployment/helm` to `charts`
180+
- Replaced distroless image with alpine in all docker images
181+
- Update EDC commit to `740c100ac162bc41b1968c232ad81f7d739aefa9`
173182

174183
## [0.1.1] - 2022-09-04
175184

@@ -178,17 +187,17 @@ connector. [documentation](/docs/migration/Version_0.1.0_0.1.1.md).
178187

179188
### Added
180189

181-
- Control-Plane Extension ([cx-oauth2](/edc-extensions/cx-oauth2/README.md))
190+
- Control-Plane Extension ([cx-oauth2](/edc-extensions/cx-oauth2/README.md))
182191

183192
### Changed
184193

185-
- Introduced git submodule to import EDC dependencies (instead of snapshot- or milestone artifact)
186-
- Helm Charts: TLS secret name is now configurable
194+
- Introduced git submodule to import EDC dependencies (instead of snapshot- or milestone artifact)
195+
- Helm Charts: TLS secret name is now configurable
187196

188197
### Fixed
189198

190-
- Connectors with Azure Vault extension are now starting
191-
again [link](https://github.com/eclipse-edc/Connector/issues/1892)
199+
- Connectors with Azure Vault extension are now starting
200+
again [link](https://github.com/eclipse-edc/Connector/issues/1892)
192201

193202
## [0.1.0] - 2022-08-19
194203

@@ -197,74 +206,74 @@ corresponding [documentation](/docs/migration/Version_0.0.x_0.1.x.md).
197206

198207
### Added
199208

200-
- Control-Plane
201-
extension ([data-plane-selector-client](https://github.com/eclipse-edc/Connector/tree/v0.0.1-milestone-5/extensions/data-plane-selector/selector-client))
202-
- run the EDC with multiple data planes at once
203-
- Control-Plane extension ([dataplane-selector-configuration](edc-extensions/dataplane-selector-configuration))
204-
- add data plane instances to the control plane by configuration
205-
- Data-Plane
206-
extension ([s3-data-plane](https://github.com/eclipse-edc/Connector/tree/main/extensions/aws/data-plane-s3))
207-
- transfer from and to AWS S3 buckets
208-
- Control-Plane extension ([data-encryption](edc-extensions/data-encryption))
209-
- Data-Plane authentication attribute transmitted during data-plane-transfer can be encrypted symmetrically (AES)
209+
- Control-Plane
210+
extension ([data-plane-selector-client](https://github.com/eclipse-edc/Connector/tree/v0.0.1-milestone-5/extensions/data-plane-selector/selector-client))
211+
- run the EDC with multiple data planes at once
212+
- Control-Plane extension ([dataplane-selector-configuration](edc-extensions/dataplane-selector-configuration))
213+
- add data plane instances to the control plane by configuration
214+
- Data-Plane
215+
extension ([s3-data-plane](https://github.com/eclipse-edc/Connector/tree/main/extensions/aws/data-plane-s3))
216+
- transfer from and to AWS S3 buckets
217+
- Control-Plane extension ([data-encryption](edc-extensions/data-encryption))
218+
- Data-Plane authentication attribute transmitted during data-plane-transfer can be encrypted symmetrically (AES)
210219

211220
### Changed
212221

213-
- Update setting name (`edc.dataplane.token.validation.endpoint` -> `edc.dataplane.token.validation.endpoint`)
214-
- EDC has been updated to
215-
version [0.0.1-20220818-SNAPSHOT](https://oss.sonatype.org/#nexus-search;gav~org.eclipse.dataspaceconnector~~0.0.1-20220818-SNAPSHOT~~) -
216-
implications to the behavior of the connector have been covered in
217-
the [corresponding migration guide](docs/migration/Version_0.0.x_0.1.x.md)
222+
- Update setting name (`edc.dataplane.token.validation.endpoint` -> `edc.dataplane.token.validation.endpoint`)
223+
- EDC has been updated to
224+
version [0.0.1-20220818-SNAPSHOT](https://oss.sonatype.org/#nexus-search;gav~org.eclipse.dataspaceconnector~~0.0.1-20220818-SNAPSHOT~~) -
225+
implications to the behavior of the connector have been covered in
226+
the [corresponding migration guide](docs/migration/Version_0.0.x_0.1.x.md)
218227

219228
### Fixed
220229

221-
- Contract-Offer-Receiving-Connectors must also pass the ContractPolicy of the ContractDefinition before receiving
222-
offers([issue](https://github.com/eclipse-edc/Connector/issues/1331))
223-
- Deletion of Asset becomes impossible when Contract Negotiation
224-
exists([issue](https://github.com/eclipse-edc/Connector/issues/1403))
225-
- Deletion of Policy becomes impossible when Contract Definition
226-
exists([issue](https://github.com/eclipse-edc/Connector/issues/1410))
230+
- Contract-Offer-Receiving-Connectors must also pass the ContractPolicy of the ContractDefinition before receiving
231+
offers([issue](https://github.com/eclipse-edc/Connector/issues/1331))
232+
- Deletion of Asset becomes impossible when Contract Negotiation
233+
exists([issue](https://github.com/eclipse-edc/Connector/issues/1403))
234+
- Deletion of Policy becomes impossible when Contract Definition
235+
exists([issue](https://github.com/eclipse-edc/Connector/issues/1410))
227236

228237
## [0.0.6] - 2022-07-29
229238

230239
### Fixed
231240

232-
- Fixes [release 0.0.5](https://github.com/eclipse-tractusx/tractusx-edc/releases/tag/0.0.5), which introduced classpath
233-
issues due to usage of [net.jodah:failsafe:2.4.3](https://search.maven.org/artifact/net.jodah/failsafe/2.4.3/jar)
234-
library
241+
- Fixes [release 0.0.5](https://github.com/eclipse-tractusx/tractusx-edc/releases/tag/0.0.5), which introduced classpath
242+
issues due to usage of [net.jodah:failsafe:2.4.3](https://search.maven.org/artifact/net.jodah/failsafe/2.4.3/jar)
243+
library
235244

236245
## [0.0.5] - 2022-07-28
237246

238247
### Added
239248

240-
- EDC Health Checks for HashiCorp Vault
249+
- EDC Health Checks for HashiCorp Vault
241250

242251
### Changed
243252

244-
- BusinessPartnerNumber constraint supports List structure
245-
- Helm: Confidential EDC settings can be set using k8s secrets
246-
- HashiCorp Vault API path configurable
253+
- BusinessPartnerNumber constraint supports List structure
254+
- Helm: Confidential EDC settings can be set using k8s secrets
255+
- HashiCorp Vault API path configurable
247256

248257
## [0.0.4] - 2022-06-27
249258

250259
### Added
251260

252-
- HashiCorp Vault Extension
253-
- Control Plane with HashiCorp Vault and PostgreSQL support
261+
- HashiCorp Vault Extension
262+
- Control Plane with HashiCorp Vault and PostgreSQL support
254263

255264
### Changed
256265

257-
- Release Workflow now publishes EDC Extensions as Maven Artifacts
266+
- Release Workflow now publishes EDC Extensions as Maven Artifacts
258267

259268
### Fixed
260269

261-
- [#1515](https://github.com/eclipse-edc/Connector/issues/1515) SQL: Connector sends out 50
262-
contract offers max.
270+
- [#1515](https://github.com/eclipse-edc/Connector/issues/1515) SQL: Connector sends out 50
271+
contract offers max.
263272

264273
### Removed
265274

266-
- CosmosDB Control Plane
267-
- Control API Extension for all Control Planes
275+
- CosmosDB Control Plane
276+
- Control API Extension for all Control Planes
268277

269278
## [0.0.3] - 2022-05-23
270279

@@ -276,7 +285,7 @@ corresponding [documentation](/docs/migration/Version_0.0.x_0.1.x.md).
276285

277286
[0.3.3]: https://github.com/eclipse-tractusx/tractusx-edc/compare/0.3.2...0.3.3
278287

279-
[0.3.2]: https://github.com/catenax-ng/tx-tractusx-edc/compare/0.3.1...0.3.2
288+
[0.3.2]: https://github.com/eclipse-tractusx/tractusx-edc/compare/0.3.1...0.3.2
280289

281290
[0.3.1]: https://github.com/eclipse-tractusx/tractusx-edc/compare/0.3.0...0.3.1
282291

0 commit comments

Comments
 (0)
Please sign in to comment.