-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo doesn't follow git-flow workflow #112
Comments
I would go for option 1 :) => gitflow. Not sure about the merge? Maybe rebase? |
@florianrusch-zf as a side note: We currently enforce main as default branch in catenax-ng to make sure security scans are done on the right branche |
Short update after we had a call today together with @wolf4ood @paullatzelsperger @stefan-ettl @SebastianBezold @stephanbcbauer. The At the moment there are only two open topics from my point of view:
|
@Siegfriedk is right. Here is the Link to our Release Guideline documenting this: https://eclipse-tractusx.github.io/docs/release/trg-2/trg-2-1 I could still add the commits from main to develop. Do you have any agreements/preferences about merge vs. rebase @florianrusch-zf ? |
I would like to postpone this topic until we (product-edc team) have some commiter in the project. I think this will make the alignment and transition smother! |
@paullatzelsperger created an DR (#177) which describes, how we wanna solve this issue. The plan is to still follow the git flow, but with different branches:
For details please have a look at the PR #177 |
Renaming/Rebranching is done |
Describe the bug
In this repository the default branch is configured to be the
main
branch and currently all PRs are merged against it and also some commits were pushed directly onmain
. If I'm correct, the Catena-X Product-EDC repository uses the git-flow, which means that only the releases were merged to themain
branch and the development happened on thedevelop
branch. That means also, that thedevelop
branch contains features and commits which weren't merged tomain
until now (e.g. on thedevelop
branch all the maven group id's were already change regarding the migration from Catena-X Product-EDC to tractusx-edc).As there are now already additional commits on the
main
branch which are not on thedevelop
, the two branches are drifted away from each other, which makes it difficult to continue the migration from Catena-X Product-EDC to tractusx-edc.Expected behavior/Possible solution
For an easier migration I would expect that the same git workflow would been used from the beginning of the migration until the end of the migration. But as it isn't the case, we need to align how we want to continue and how to clean up the repository again and if we still want to go with the git flow or not.
If we want to go with the git flow, I would recommend to do the following to clean up the repository again:
main
intodevelop
and fix all the merge conflicsdevelop
the default branchIf we don't want to go with the git flow:
develop
intomain
and fix all the merge conflicsmain
as the starting point for what ever git workflow we want to followThe text was updated successfully, but these errors were encountered: