Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: extract the checkout and setup-java action into a re-usable action #231

Closed
paullatzelsperger opened this issue Apr 17, 2023 · 0 comments · Fixed by #246
Closed

CI: extract the checkout and setup-java action into a re-usable action #231

paullatzelsperger opened this issue Apr 17, 2023 · 0 comments · Fixed by #246
Assignees
Labels
gh-actions good first issue Good for newcomers refactoring Refactoring, does not add functionality

Comments

@paullatzelsperger
Copy link
Contributor

paullatzelsperger commented Apr 17, 2023

WHAT

The checkout and setup-java actions should be extracted into a re-usable composite action.

In many workflow files we find multiple blocks of

      # Set-Up
      - name: Checkout
        uses: actions/checkout@v3.3.0
      - name: Set up JDK 11
        uses: actions/setup-java@v3.11.0
        with:
          java-version: '17'
          distribution: 'temurin'
          cache: 'gradle'

which not only contains a small bug ("Set up JDK 11" instead of "17"), but it is also repetitive.

WHY

avoid duplication, create consistency, one place to maintain the code, e.g. for version upgrades

@paullatzelsperger paullatzelsperger added good first issue Good for newcomers refactoring Refactoring, does not add functionality gh-actions labels Apr 17, 2023
@paullatzelsperger paullatzelsperger moved this to Todo in EDC Board Apr 17, 2023
@tuncaytunc-zf tuncaytunc-zf self-assigned this Apr 18, 2023
@paullatzelsperger paullatzelsperger moved this from Todo to In Progress in EDC Board Apr 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in EDC Board Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh-actions good first issue Good for newcomers refactoring Refactoring, does not add functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants