Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenor sax, bari sax wrong fingerings #19

Closed
angusmoncrieff opened this issue Sep 16, 2020 · 2 comments · Fixed by #20
Closed

Tenor sax, bari sax wrong fingerings #19

angusmoncrieff opened this issue Sep 16, 2020 · 2 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@angusmoncrieff
Copy link

Hi there,

It seems the fingerings for tenor and bari are all offset - see screenshot attached: C major should have same fingerings for all the saxes, but tenor and bari are blank for first notes, and then the fingerings that do appear are wrong.

If I'm understanding the code correctly, I think this is the fix:

            if (instrument === 'wind.reed.saxophone.alto') {
                this.transpose = 7;
            } else if (instrument === 'wind.reed.saxophone.tenor') {
                this.transpose = 12;         // was 5 - tenor sounds an octave lower than sop
            } else if (instrument === 'wind.reed.saxophone.baritone') {
                this.transpose = 19;         // was 7
                this.base += '\uE281';
            }

Many thanks for your great plugin. FYI I'm 'borrowing' the logic/codes for a web app I'm building - hope that's ok? Will credit you.

Regards,
Angus

Screenshot 2020-09-16 at 16 18 15

@eduardomourar eduardomourar added the bug Something isn't working label Sep 16, 2020
@eduardomourar
Copy link
Owner

@gusmoney, thanks for reporting this bug and a fix. In regards to the code, feel free to use it and the Fiati font as well. I am fine just pointing to this repository. I would suggest adding the fiati-regular.woff to your web app, because it is a smaller version of the font. I have not really tried the woff one, so I would appreciate if you can give me your feedback here (or in Fiati repo in case of a bug) .

@eduardomourar
Copy link
Owner

Released v1.4.0 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants