Fix a bug where error not displaying when connector misconfigured (#117348)

scottybollinger · web-flow · commit 6c4373fb6c00 · 2021-11-03T11:08:13.000-07:00
This PR fixes a bug where the error was not displaying when misconfigured connector was connected and redirected back. The issue was that the redirect was occuring after the flash message was set and the fix was to redirect and then show the flash message
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/add_source_logic.ts b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/add_source_logic.ts
@@ -546,8 +546,8 @@ export const AddSourceLogic = kea<MakeLogicType<AddSourceValues, AddSourceAction
           navigateToUrl(getSourcesPath(SOURCES_PATH, isOrganization));
         }
       } catch (e) {
-        flashAPIErrors(e);
         navigateToUrl(getSourcesPath(SOURCES_PATH, isOrganization));
+        flashAPIErrors(e);
       }
     },
     createContentSource: async ({ serviceType, successCallback, errorCallback }) => {

Original file line number	Diff line number	Diff line change
`@@ -546,8 +546,8 @@ export const AddSourceLogic = kea<MakeLogicType<AddSourceValues, AddSourceAction`
`546`	`546`	`navigateToUrl(getSourcesPath(SOURCES_PATH, isOrganization));`
`547`	`547`	`}`
`548`	`548`	`} catch (e) {`
`549`		`- flashAPIErrors(e);`
`550`	`549`	`navigateToUrl(getSourcesPath(SOURCES_PATH, isOrganization));`
	`550`	`+ flashAPIErrors(e);`
`551`	`551`	`}`
`552`	`552`	`},`
`553`	`553`	`createContentSource: async ({ serviceType, successCallback, errorCallback }) => {`