Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 6ca6708

Browse files
committedJul 29, 2020
Add link to the nodejs/node issue documenting net.Socket:timeout
1 parent 6cc4fc1 commit 6ca6708

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed
 

‎src/core/server/http/http_server.test.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -1005,7 +1005,8 @@ describe('idle socket timeout', () => {
10051005
validate: { body: schema.any() },
10061006
},
10071007
(context, req, res) => {
1008-
// net.Socket::timeout isn't documented or part of the types, yet...
1008+
// net.Socket#timeout isn't documented. Once https://github.com/nodejs/node/pull/34543 merges,
1009+
// IKibanaSocket can expose the socket timeout, so we don't have to do this ugly casting to any
10091010
return res.ok({ body: { socketTimeout: (req.socket as any).socket.timeout } });
10101011
}
10111012
);
@@ -1029,7 +1030,8 @@ describe('idle socket timeout', () => {
10291030
options: { timeout: { idleSocket: routeIdleSocketTimeout } },
10301031
},
10311032
(context, req, res) => {
1032-
// net.Socket::timeout isn't documented or part of the types, yet...
1033+
// net.Socket#timeout isn't documented. Once https://github.com/nodejs/node/pull/34543 merges,
1034+
// IKibanaSocket can expose the socket timeout, so we don't have to do this ugly casting to any
10331035
return res.ok({ body: { socketTimeout: (req.socket as any).socket.timeout } });
10341036
}
10351037
);

0 commit comments

Comments
 (0)
Please sign in to comment.