Skip to content

Commit 938d689

Browse files
Replace partial aspect with whole aspect value
1 parent 11251b7 commit 938d689

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

src/plugins/vis_types/xy/public/utils/accessors.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ export const getSplitSeriesAccessorFnMap = (
8282
export const isPercentileIdEqualToSeriesId = (columnId: number | string, seriesColumnId: string) =>
8383
columnId.toString().split('.')[0] === seriesColumnId;
8484

85-
export const isValidSeriesForDimension = (
86-
seriesColumnId: string,
87-
{ aggId, accessor }: Partial<Aspect>
88-
) =>
85+
export const isValidSeriesForDimension = (seriesColumnId: string, { aggId, accessor }: Aspect) =>
8986
(aggId === seriesColumnId || isPercentileIdEqualToSeriesId(aggId ?? '', seriesColumnId)) &&
9087
accessor !== null;

src/plugins/vis_types/xy/public/utils/render_all_series.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@ export const renderAllSeries = (
8282
interpolate,
8383
type,
8484
}) => {
85-
const yAspects = aspects.y.filter(({ aggId, accessor }) =>
86-
isValidSeriesForDimension(paramId, { aggId, accessor })
87-
);
85+
const yAspects = aspects.y.filter((aspect) => isValidSeriesForDimension(paramId, aspect));
8886
if (!show || !yAspects.length) {
8987
return null;
9088
}

0 commit comments

Comments
 (0)