Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] REGRESSION: Metric threshold alert previews only look back one bucket #107672

Closed
Zacqary opened this issue Aug 4, 2021 · 1 comment · Fixed by #107674
Closed

[Metrics UI] REGRESSION: Metric threshold alert previews only look back one bucket #107672

Zacqary opened this issue Aug 4, 2021 · 1 comment · Fixed by #107674
Assignees
@Zacqary
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature regression Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.1

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Aug 4, 2021 •
edited
Loading

A hotfix to Metric Threshold alerts (https://github.com/elastic/kibana/pull/106947/files#diff-bb5393c086e685993db2ac415c87a6b39151e97c0c1785aaff95981e41aae780L79-L83) accidentally removed logic that was necessary for alert previews to generate multiple buckets of data.

All metric previews will only ever say, at most, There was 1 instance that satisfied the conditions of the alert.

We need to:

  • Restore this logic while preserving the bugfix
  • Add a test to guard against bucket lookback logic being removed again
@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience regression Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.1 labels Aug 4, 2021
@Zacqary Zacqary self-assigned this Aug 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary mentioned this issue Aug 4, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature regression Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metrics UI] Fix metric threshold preview regression Zacqary/kibana
2 participants
@Zacqary @elasticmachine