Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Add support of native event handlers from expressions in renderers at Canvas. #122085

Closed
Kuznietsov opened this issue Dec 28, 2021 · 5 comments
Assignees
Labels
estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) research Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Kuznietsov
Copy link
Contributor

Kuznietsov commented Dec 28, 2021

Introduction

At [canvas] remove filters function it is mentioned, that filtersManager need to be filled with Filter[] by emitting applyFilterAction event. Unfortunately, Canvas is not supporting native events from expressions. It provides its own handlers. So, for now, it is impossible to archive the goal of using events.

So, before, we need to move Canvas renderers from the custom renderer to the expressions' one. Detailed description is written at the issue.

After, need to replace custom filtersManager with data.query.filterManager (in a separate PR).

cc @crob611, @ppisljar.

@Kuznietsov Kuznietsov added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) research Feature:Canvas estimate:needs-research Estimated as too large and requires research to break down into workable issues labels Dec 28, 2021
@Kuznietsov Kuznietsov self-assigned this Dec 28, 2021
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Dec 28, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 28, 2021
@Kuznietsov Kuznietsov changed the title [Canvas] Add support of native handlers in renderers at Canvas. [Canvas] Add support of native event handlers from expressions in renderers at Canvas. Dec 29, 2021
@ppisljar
Copy link
Member

ppisljar commented Jan 4, 2022

in the meantime above could be worked around by implementing a custom applyFilterAction handler in canvas, which does exactly the same, adds filter to the filter manager.

@Kuznietsov
Copy link
Contributor Author

@ppisljar, do you want it as a temporary solution or the final one?

@ppisljar
Copy link
Member

ppisljar commented Jan 4, 2022

temporary, to allow us to progress with unifying filtering.

@Kuznietsov
Copy link
Contributor Author

Kuznietsov commented Jan 4, 2022

@ppisljar, great, I'll address it after merging the PR #119044.

And as it is a temp solution, I'll leave this issue open for further implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) research Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants