From 697ed2f481c3f8341d17b5fb58c36c8db85d875e Mon Sep 17 00:00:00 2001 From: Jeonguk Choi <91456421+cjeonguk@users.noreply.github.com> Date: Sat, 3 Sep 2022 23:27:20 +0900 Subject: [PATCH 1/3] docs: fix typo --- docs/generated/NsisOptions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/generated/NsisOptions.md b/docs/generated/NsisOptions.md index f2086fb959f..4540e237231 100644 --- a/docs/generated/NsisOptions.md +++ b/docs/generated/NsisOptions.md @@ -37,8 +37,8 @@

script String | “undefined” - The path to NSIS script to customize installer. Defaults to build/installer.nsi. See Custom NSIS script.

  • -

    license String | “undefined” - The path to EULA license file. Defaults to license.txt or eula.txt (or uppercase variants). In addition to txt, rtfandhtmlsupported (don't forget to usetarget="_blank"` for links).

    -

    Multiple license files in different languages are supported — use lang postfix (e.g. _de, _ru)). For example, create files license_de.txt and license_en.txt in the build resources. If OS language is german, license_de.txt will be displayed. See map of language code to name.

    +

    license String | “undefined” - The path to EULA license file. Defaults to license.txt or eula.txt (or uppercase variants). In addition to txt, rtf and html supported (don't forget to use target="_blank" for links).

    +

    Multiple license files in different languages are supported — use lang postfix (e.g. _de, _ru). For example, create files license_de.txt and license_en.txt in the build resources. If OS language is german, license_de.txt will be displayed. See map of language code to name.

    Appropriate license file will be selected by user OS language.

  • From f4ca535b2c2d702d0149a32ae83cf1f34b3460de Mon Sep 17 00:00:00 2001 From: Jeonguk Choi <91456421+cjeonguk@users.noreply.github.com> Date: Sun, 4 Sep 2022 11:10:44 +0900 Subject: [PATCH 2/3] Update jsdoc code --- docs/generated/NsisOptions.md | 2 +- packages/app-builder-lib/scheme.json | 4 ++-- packages/app-builder-lib/src/targets/nsis/nsisOptions.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/generated/NsisOptions.md b/docs/generated/NsisOptions.md index 4540e237231..0d6b3555813 100644 --- a/docs/generated/NsisOptions.md +++ b/docs/generated/NsisOptions.md @@ -37,7 +37,7 @@

    script String | “undefined” - The path to NSIS script to customize installer. Defaults to build/installer.nsi. See Custom NSIS script.

  • -

    license String | “undefined” - The path to EULA license file. Defaults to license.txt or eula.txt (or uppercase variants). In addition to txt, rtf and html supported (don't forget to use target="_blank" for links).

    +

    license String | “undefined” - The path to EULA license file. Defaults to license.txt or eula.txt (or uppercase variants). In addition to txt, rtf and html supported (don’t forget to use target="_blank" for links).

    Multiple license files in different languages are supported — use lang postfix (e.g. _de, _ru). For example, create files license_de.txt and license_en.txt in the build resources. If OS language is german, license_de.txt will be displayed. See map of language code to name.

    Appropriate license file will be selected by user OS language.

  • diff --git a/packages/app-builder-lib/scheme.json b/packages/app-builder-lib/scheme.json index b737381af4d..27869369333 100644 --- a/packages/app-builder-lib/scheme.json +++ b/packages/app-builder-lib/scheme.json @@ -3785,7 +3785,7 @@ ] }, "license": { - "description": "The path to EULA license file. Defaults to `license.txt` or `eula.txt` (or uppercase variants). In addition to `txt, `rtf` and `html` supported (don't forget to use `target=\"_blank\"` for links).\n\nMultiple license files in different languages are supported — use lang postfix (e.g. `_de`, `_ru`)). For example, create files `license_de.txt` and `license_en.txt` in the build resources.\nIf OS language is german, `license_de.txt` will be displayed. See map of [language code to name](https://github.com/meikidd/iso-639-1/blob/master/src/data.js).\n\nAppropriate license file will be selected by user OS language.", + "description": "The path to EULA license file. Defaults to `license.txt` or `eula.txt` (or uppercase variants). In addition to `txt`, `rtf` and `html` supported (don't forget to use `target=\"_blank\"` for links).\n\nMultiple license files in different languages are supported — use lang postfix (e.g. `_de`, `_ru`). For example, create files `license_de.txt` and `license_en.txt` in the build resources.\nIf OS language is german, `license_de.txt` will be displayed. See map of [language code to name](https://github.com/meikidd/iso-639-1/blob/master/src/data.js).\n\nAppropriate license file will be selected by user OS language.", "type": [ "null", "string" @@ -4103,7 +4103,7 @@ ] }, "license": { - "description": "The path to EULA license file. Defaults to `license.txt` or `eula.txt` (or uppercase variants). In addition to `txt, `rtf` and `html` supported (don't forget to use `target=\"_blank\"` for links).\n\nMultiple license files in different languages are supported — use lang postfix (e.g. `_de`, `_ru`)). For example, create files `license_de.txt` and `license_en.txt` in the build resources.\nIf OS language is german, `license_de.txt` will be displayed. See map of [language code to name](https://github.com/meikidd/iso-639-1/blob/master/src/data.js).\n\nAppropriate license file will be selected by user OS language.", + "description": "The path to EULA license file. Defaults to `license.txt` or `eula.txt` (or uppercase variants). In addition to `txt`, `rtf` and `html` supported (don't forget to use `target=\"_blank\"` for links).\n\nMultiple license files in different languages are supported — use lang postfix (e.g. `_de`, `_ru`). For example, create files `license_de.txt` and `license_en.txt` in the build resources.\nIf OS language is german, `license_de.txt` will be displayed. See map of [language code to name](https://github.com/meikidd/iso-639-1/blob/master/src/data.js).\n\nAppropriate license file will be selected by user OS language.", "type": [ "null", "string" diff --git a/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts b/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts index 921fb7e06cb..a322de342da 100644 --- a/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts +++ b/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts @@ -132,9 +132,9 @@ export interface NsisOptions extends CommonNsisOptions, CommonWindowsInstallerCo readonly script?: string | null /** - * The path to EULA license file. Defaults to `license.txt` or `eula.txt` (or uppercase variants). In addition to `txt, `rtf` and `html` supported (don't forget to use `target="_blank"` for links). + * The path to EULA license file. Defaults to `license.txt` or `eula.txt` (or uppercase variants). In addition to `txt`, `rtf` and `html` supported (don't forget to use `target="_blank"` for links). * - * Multiple license files in different languages are supported — use lang postfix (e.g. `_de`, `_ru`)). For example, create files `license_de.txt` and `license_en.txt` in the build resources. + * Multiple license files in different languages are supported — use lang postfix (e.g. `_de`, `_ru`). For example, create files `license_de.txt` and `license_en.txt` in the build resources. * If OS language is german, `license_de.txt` will be displayed. See map of [language code to name](https://github.com/meikidd/iso-639-1/blob/master/src/data.js). * * Appropriate license file will be selected by user OS language. From 0bb719c38f20d39312346b3eb715c7237f69755f Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Wed, 7 Sep 2022 08:09:04 -0700 Subject: [PATCH 3/3] Create smart-countries-decide.md --- .changeset/smart-countries-decide.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/smart-countries-decide.md diff --git a/.changeset/smart-countries-decide.md b/.changeset/smart-countries-decide.md new file mode 100644 index 00000000000..75ce8dd56c2 --- /dev/null +++ b/.changeset/smart-countries-decide.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +fix(docs): typo of docs/generated/NsisOptions.md.