Skip to content

Commit ae54e37

Browse files
test: support 'latest'/'latest@X' Electron version strings (#37867)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
1 parent 4de542d commit ae54e37

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

script/spec-runner.js

+15-1
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,24 @@ if (args.runners !== undefined) {
6464
async function main () {
6565
if (args.electronVersion) {
6666
const versions = await ElectronVersions.create();
67-
if (!versions.isVersion(args.electronVersion)) {
67+
if (args.electronVersion === 'latest') {
68+
args.electronVersion = versions.latest.version;
69+
} else if (args.electronVersion.startsWith('latest@')) {
70+
const majorVersion = parseInt(args.electronVersion.slice('latest@'.length));
71+
const ver = versions.inMajor(majorVersion).slice(-1)[0];
72+
if (ver) {
73+
args.electronVersion = ver.version;
74+
} else {
75+
console.log(`${fail} '${majorVersion}' is not a recognized Electron major version`);
76+
process.exit(1);
77+
}
78+
} else if (!versions.isVersion(args.electronVersion)) {
6879
console.log(`${fail} '${args.electronVersion}' is not a recognized Electron version`);
6980
process.exit(1);
7081
}
82+
83+
const versionString = `v${args.electronVersion}`;
84+
console.log(`Running against Electron ${versionString.green}`);
7185
}
7286

7387
const [lastSpecHash, lastSpecInstallHash] = loadLastSpecHash();

0 commit comments

Comments
 (0)