Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit ca3e746

Browse files
Trottjasonrudolph
authored andcommitted
test: make test-tls-external-accessor agnostic
Remove reliance on V8-specific error messages in test/parallel/test-tls-external-accessor.js. Check that the error is a `TypeError`. The test should now be successful without modification using ChakraCore. Backport-PR-URL: nodejs/node#20456 PR-URL: nodejs/node#16272 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent a3e6208 commit ca3e746

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-tls-external-accessor.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ const tls = require('tls');
1111
{
1212
const pctx = tls.createSecureContext().context;
1313
const cctx = Object.create(pctx);
14-
assert.throws(() => cctx._external, /incompatible receiver/);
14+
assert.throws(() => cctx._external, TypeError);
1515
pctx._external;
1616
}
1717
{
1818
const pctx = tls.createSecurePair().credentials.context;
1919
const cctx = Object.create(pctx);
20-
assert.throws(() => cctx._external, /incompatible receiver/);
20+
assert.throws(() => cctx._external, TypeError);
2121
pctx._external;
2222
}

0 commit comments

Comments
 (0)