Skip to content

Commit 7c4ebe5

Browse files
Remove the workaround for sql container (#44)
The workaround for the SQL Server container is not needed anymore Co-authored-by: Romeo Dumitrescu <romeo@drc.ro>
1 parent 51b16de commit 7c4ebe5

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

src/ES.FX.Microsoft.EntityFrameworkCore.SqlServer/ES.FX.Microsoft.EntityFrameworkCore.SqlServer.csproj

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
<Nullable>enable</Nullable>
77
</PropertyGroup>
88

9-
<ItemGroup>
10-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.8" />
11-
<PackageReference Include="Testcontainers.MsSql" Version="3.10.0" />
12-
</ItemGroup>
9+
<ItemGroup>
10+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.8" />
11+
<PackageReference Include="Testcontainers.MsSql" Version="3.10.0" />
12+
</ItemGroup>
1313

1414
<ItemGroup>
1515
<ProjectReference Include="..\ES.FX.Microsoft.EntityFrameworkCore\ES.FX.Microsoft.EntityFrameworkCore.csproj" />

tests/ES.FX.Shared.SqlServer.Tests/Fixtures/SqlServerContainerFixture.cs

+1-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using DotNet.Testcontainers.Builders;
2-
using Testcontainers.MsSql;
1+
using Testcontainers.MsSql;
32

43
namespace ES.FX.Shared.SqlServer.Tests.Fixtures;
54

@@ -15,15 +14,6 @@ public async Task InitializeAsync()
1514
Container = new MsSqlBuilder()
1615
.WithName($"{nameof(SqlServerContainerFixture)}-{Guid.NewGuid()}")
1716
.WithImage($"{Registry}/{Image}:{Tag}")
18-
// FIXME until this is fixed https://github.com/testcontainers/testcontainers-dotnet/pull/1221
19-
.WithWaitStrategy(Wait.ForUnixContainer()
20-
.UntilCommandIsCompleted(
21-
"/opt/mssql-tools18/bin/sqlcmd",
22-
"-C",
23-
"-Q",
24-
"SELECT 1;"
25-
)
26-
)
2717
.Build();
2818
await Container.StartAsync();
2919
}

0 commit comments

Comments
 (0)