Skip to content

Commit 37b1e15

Browse files
authored
Fix: hint text follows the alignment set on the TextEdit (#4889)
Updated the `show_content` method of the `TextEdit` widget so that the requested text alignment (if any) is also applied to the hint text. Currently, hint text is always aligned to the top left of the widget, which may be inconsistent with the actual location of text entered by the user. I think it's more intuitive for the hint text to be positioned as if the user had entered the same text themselves. Here are some comparisons of the difference between how the hint text and the entered text looks, before and after this change: ### Previous Behaviour ![Prev](https://github.com/user-attachments/assets/8cd7858f-833e-4946-84f1-ff1ede60c64d) ### Updated Behaviour ![Update](https://github.com/user-attachments/assets/2596dd44-d6f9-4376-9012-5b074fc2cdea) * [x] I have followed the instructions in the PR template
1 parent 7736192 commit 37b1e15

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

crates/egui/src/widgets/text_edit/builder.rs

+5-1
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,11 @@ impl<'t> TextEdit<'t> {
682682
hint_text_font_id,
683683
)
684684
};
685-
painter.galley(rect.min, galley, hint_text_color);
685+
let galley_pos = align
686+
.align_size_within_rect(galley.size(), rect)
687+
.intersect(rect)
688+
.min;
689+
painter.galley(galley_pos, galley, hint_text_color);
686690
}
687691

688692
if ui.memory(|mem| mem.has_focus(id)) {

0 commit comments

Comments
 (0)