Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support method PATCH #108

Open
ComLock opened this issue Jul 26, 2023 · 2 comments
Open

Support method PATCH #108

ComLock opened this issue Jul 26, 2023 · 2 comments
Labels
enhancement

Comments

@ComLock
Copy link
Collaborator

ComLock commented Jul 26, 2023

The HTTP 1.1 RFC doesn't define method PATCH, but it mentions it's RFC
https://datatracker.ietf.org/doc/html/rfc7231#page-29

https://datatracker.ietf.org/doc/html/rfc5789

I can use router.all to implement method OPTIONS, but method PATCH fails before the callback, so I cannot use router.all to implement method PATCH.

Thus I currently don't know of a workaround to support method PATCH.
@ComLock
Copy link
Collaborator Author

ComLock commented Jul 26, 2023

The problem is not lib-router, but XP enonic/xp#9131

@rymsha
Copy link
Contributor

rymsha commented Jul 27, 2023

The problem is not lib-router

lib-router has to be updated when XP supports PATCH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ComLock @rymsha