Include syllabus for data carpentry #130
Closed
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The motivation behind this is fine I think. Although, I'm wondering if there should be some way to make sure the "concepts" stay aligned between the two flavours. E.g. the same domain specific topics should be covered in both flavours, while diverging on the language specific points. That said, I don't think I can review the changes. I assume the markdown files are Jinja2 templates? I don't really know exactly how they are processed when the site is published, so don't feel confident in commenting. |
|
Fixed with #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
This relies on directories in workshop-metadata for data carpentry workshops to be in format {curriculum}-{flavor}. Where flavor is "python" or "r". We would have to change https://github.com/esciencecenter-digital-skills/workshop-metadata/tree/main/dc-astronomy to dc-astronomy-python.
I chose this, because this allows us to have unique workshop-metadata directories for different flavours of the same curriculum.