Merge pull request #6429 from espoon-voltti/auth-small-fixes-part-4

Korjataan bugi jonka takia salasanassa ei voinut olla välilyöntejä alussa tai lopussa

Author: Gekkio

frontend/src/citizen-frontend/login/WeakLoginFormPage.tsx

@@ -8,7 +8,7 @@ import { Navigate, useSearchParams } from 'react-router'
 import { authWeakLogin } from 'citizen-frontend/auth/api'
 import { wrapResult } from 'lib-common/api'
 import { string } from 'lib-common/form/fields'
-import { object, required, validated } from 'lib-common/form/form'
+import { object, required, validated, value } from 'lib-common/form/form'
 import { useForm, useFormFields } from 'lib-common/form/hooks'
 import { nonBlank } from 'lib-common/form/validators'
 import { parseUrlWithOrigin } from 'lib-common/utils/parse-url-with-origin'
@@ -67,7 +67,8 @@ export default React.memo(function WeakLoginFormPage() {
 
 const weakLoginForm = object({
   username: validated(required(string()), nonBlank),
-  password: validated(required(string()), nonBlank)
+  // value<string> is used to avoid trimming
+  password: validated(required(value<string>()), nonBlank)
 })
 
 const authWeakLoginResult = wrapResult(authWeakLogin)
@@ -134,9 +135,10 @@ const WeakLoginForm = React.memo(function WeakLogin({
           type="submit"
           text={t.link}
           disabled={!form.isValid()}
-          onClick={() =>
-            authWeakLoginResult(form.state.username, form.state.password)
-          }
+          onClick={() => {
+            const { username, password } = form.value()
+            return authWeakLoginResult(username, password)
+          }}
           onSuccess={() => window.location.replace(nextUrl ?? '/')}
           onFailure={(error) => {
             if (error.statusCode === 429) {

frontend/src/citizen-frontend/personal-details/LoginDetailsSection.tsx

@@ -7,8 +7,7 @@ import styled from 'styled-components'
 
 import ModalAccessibilityWrapper from 'citizen-frontend/ModalAccessibilityWrapper'
 import { Failure } from 'lib-common/api'
-import { string } from 'lib-common/form/fields'
-import { object, required, validated } from 'lib-common/form/form'
+import { object, required, validated, value } from 'lib-common/form/form'
 import { useBoolean, useForm, useFormFields } from 'lib-common/form/hooks'
 import { EmailVerificationStatusResponse } from 'lib-common/generated/api-types/pis'
 import { PasswordConstraints } from 'lib-common/generated/api-types/shared'
@@ -233,12 +232,13 @@ const WeakCredentialsFormModal = React.memo(function WeakCredentialsFormModal({
     () =>
       validated(
         object({
-          password: validated(required(string()), (password) =>
+          // value<string> is used to avoid trimming
+          password: validated(required(value<string>()), (password) =>
             isPasswordStructureValid(passwordConstraints, password)
               ? undefined
               : 'passwordFormat'
           ),
-          confirmPassword: required(string())
+          confirmPassword: required(value<string>())
         }),
         (form) =>
           form.password !== form.confirmPassword