Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Fable run on .NET 5? #2294

Closed
psfinaki opened this issue Nov 24, 2020 · 5 comments
Closed

Does Fable run on .NET 5? #2294

psfinaki opened this issue Nov 24, 2020 · 5 comments

Comments

@psfinaki
Copy link

Description

I am trying to update my app to use .NET 5 and F# 5, to benefit from string interpolation and other things. Fable app is currently on .NET Core 3.1.

I know switching target framework is always a traumatizing experience but I am running out of ideas what else to do. I retargeted the app to net5.0, updated all the Fable packages, updated fable-loader and fable-compiler...

I found this app successfully working on .NET 5 but it's already working via Nagareyama stuff. Is it supposed to be possible to run things without Nagareyama? I read the Fable blog but this stuff is still kind of magic for me.

@alfonsogarciacaro
Copy link
Member

Actually, for Fable apps the .net target framework should not be relevant, but I guess you're interested in F# 5 features. Fable 2 supports some of them but not string interpolation. We are very close to publish an official release of Fable 3 so I'd recommend upgrading to get latest features and fixes. Here's a guide for upgrading apps using Webpack: MangelMaxime/fulma-demo#43

In order for latest features to work both with Fable and your IDE you need two things:

  • Reference FSharp.Core 5.0
  • Add <LangVersion>5.0</LangVersion> property to your .fsproj (or preview instead of 5.0)

I think these are automatic when using dotnet sdk 5 regardless of the target framework.

@psfinaki
Copy link
Author

psfinaki commented Dec 1, 2020

@alfonsogarciacaro, alright, thanks for the response. I guess this PR should be somehow more visible, that would help a lot :)

@alfonsogarciacaro
Copy link
Member

Yes, visibility is always and issue :/ It's mentioned in the recent blog posts but I haven't updated the landing page yet because Fable 3 is not officially released. That will happen soon.

@psfinaki
Copy link
Author

psfinaki commented Dec 1, 2020

Alright. I got my response, and I checked things are working with the latest Fable RC. You can close the issue, or close it once Fable is officially released - it's on you :)

@alfonsogarciacaro
Copy link
Member

Thanks for confirming @psfinaki! Ok, let's close it as we are not working on Fable 2 branch, so new issues are only filled for Fable 3 👍

@psfinaki psfinaki closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants