Skip to content

Commit 56d7366

Browse files
disylhfacebook-github-bot
disylh
authored and
facebook-github-bot
committed
codegen change for BigValueRoute as manual RH
Summary: As title Reviewed By: stuclar Differential Revision: D71165322 fbshipit-source-id: fe5786ad963ae0c8c19717858eae8f93807a05bb
1 parent c92ddd1 commit 56d7366

15 files changed

+84
-2
lines changed

‎mcrouter/lib/carbon/example/gen/HelloGoodbyeRouterInfo-ExternTemplate.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <mcrouter/routes/AllInitialRouteFactory.h>
2424
#include <mcrouter/routes/AllMajorityRouteFactory.h>
2525
#include <mcrouter/routes/AllSyncRouteFactory.h>
26+
#include <mcrouter/routes/BigValueRoute.h>
2627
#include <mcrouter/routes/BlackholeRoute.h>
2728
#include <mcrouter/routes/DevNullRoute.h>
2829
#include <mcrouter/routes/ErrorRoute.h>
@@ -69,6 +70,11 @@ makeAllSyncRoute<hellogoodbye::HelloGoodbyeRouterInfo>(
6970
RouteHandleFactory<hellogoodbye::HelloGoodbyeRouterInfo::RouteHandleIf>& factory,
7071
const folly::dynamic& json);
7172

73+
template hellogoodbye::HelloGoodbyeRouterInfo::RouteHandlePtr
74+
makeBigValueRoute<hellogoodbye::HelloGoodbyeRouterInfo>(
75+
RouteHandleFactory<hellogoodbye::HelloGoodbyeRouterInfo::RouteHandleIf>& factory,
76+
const folly::dynamic& json);
77+
7278
template hellogoodbye::HelloGoodbyeRouterInfo::RouteHandlePtr
7379
makeBlackholeRoute<hellogoodbye::HelloGoodbyeRouterInfo>(
7480
RouteHandleFactory<hellogoodbye::HelloGoodbyeRouterInfo::RouteHandleIf>& factory,

‎mcrouter/lib/carbon/example/gen/HelloGoodbyeRouterInfo.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <mcrouter/routes/AllInitialRouteFactory.h>
2929
#include <mcrouter/routes/AllMajorityRouteFactory.h>
3030
#include <mcrouter/routes/AllSyncRouteFactory.h>
31+
#include <mcrouter/routes/BigValueRoute.h>
3132
#include <mcrouter/routes/BlackholeRoute.h>
3233
#include <mcrouter/routes/DevNullRoute.h>
3334
#include <mcrouter/routes/ErrorRoute.h>
@@ -82,6 +83,11 @@ makeAllSyncRoute<hellogoodbye::HelloGoodbyeRouterInfo>(
8283
RouteHandleFactory<hellogoodbye::HelloGoodbyeRouterInfo::RouteHandleIf>& factory,
8384
const folly::dynamic& json);
8485

86+
extern template hellogoodbye::HelloGoodbyeRouterInfo::RouteHandlePtr
87+
makeBigValueRoute<hellogoodbye::HelloGoodbyeRouterInfo>(
88+
RouteHandleFactory<hellogoodbye::HelloGoodbyeRouterInfo::RouteHandleIf>& factory,
89+
const folly::dynamic& json);
90+
8591
extern template hellogoodbye::HelloGoodbyeRouterInfo::RouteHandlePtr
8692
makeBlackholeRoute<hellogoodbye::HelloGoodbyeRouterInfo>(
8793
RouteHandleFactory<hellogoodbye::HelloGoodbyeRouterInfo::RouteHandleIf>& factory,
@@ -170,6 +176,7 @@ HelloGoodbyeRouterInfo::buildRouteMap() {
170176
{"AllInitialRoute", &makeAllInitialRoute<HelloGoodbyeRouterInfo>},
171177
{"AllMajorityRoute", &makeAllMajorityRoute<HelloGoodbyeRouterInfo>},
172178
{"AllSyncRoute", &makeAllSyncRoute<HelloGoodbyeRouterInfo>},
179+
{"BigValueRoute", &makeBigValueRoute<HelloGoodbyeRouterInfo>},
173180
{"BlackholeRoute", &makeBlackholeRoute<HelloGoodbyeRouterInfo>},
174181
{"DevNullRoute", &makeDevNullRoute<HelloGoodbyeRouterInfo>},
175182
{"ErrorRoute", &makeErrorRoute<HelloGoodbyeRouterInfo>},

‎mcrouter/lib/carbon/test/gen/ARouterInfo-ExternTemplate.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <mcrouter/routes/AllInitialRouteFactory.h>
2424
#include <mcrouter/routes/AllMajorityRouteFactory.h>
2525
#include <mcrouter/routes/AllSyncRouteFactory.h>
26+
#include <mcrouter/routes/BigValueRoute.h>
2627
#include <mcrouter/routes/BlackholeRoute.h>
2728
#include <mcrouter/routes/DevNullRoute.h>
2829
#include <mcrouter/routes/ErrorRoute.h>
@@ -69,6 +70,11 @@ makeAllSyncRoute<carbon::test::A::ARouterInfo>(
6970
RouteHandleFactory<carbon::test::A::ARouterInfo::RouteHandleIf>& factory,
7071
const folly::dynamic& json);
7172

73+
template carbon::test::A::ARouterInfo::RouteHandlePtr
74+
makeBigValueRoute<carbon::test::A::ARouterInfo>(
75+
RouteHandleFactory<carbon::test::A::ARouterInfo::RouteHandleIf>& factory,
76+
const folly::dynamic& json);
77+
7278
template carbon::test::A::ARouterInfo::RouteHandlePtr
7379
makeBlackholeRoute<carbon::test::A::ARouterInfo>(
7480
RouteHandleFactory<carbon::test::A::ARouterInfo::RouteHandleIf>& factory,

‎mcrouter/lib/carbon/test/gen/ARouterInfo.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <mcrouter/routes/AllInitialRouteFactory.h>
2929
#include <mcrouter/routes/AllMajorityRouteFactory.h>
3030
#include <mcrouter/routes/AllSyncRouteFactory.h>
31+
#include <mcrouter/routes/BigValueRoute.h>
3132
#include <mcrouter/routes/BlackholeRoute.h>
3233
#include <mcrouter/routes/DevNullRoute.h>
3334
#include <mcrouter/routes/ErrorRoute.h>
@@ -79,6 +80,11 @@ makeAllSyncRoute<carbon::test::A::ARouterInfo>(
7980
RouteHandleFactory<carbon::test::A::ARouterInfo::RouteHandleIf>& factory,
8081
const folly::dynamic& json);
8182

83+
extern template carbon::test::A::ARouterInfo::RouteHandlePtr
84+
makeBigValueRoute<carbon::test::A::ARouterInfo>(
85+
RouteHandleFactory<carbon::test::A::ARouterInfo::RouteHandleIf>& factory,
86+
const folly::dynamic& json);
87+
8288
extern template carbon::test::A::ARouterInfo::RouteHandlePtr
8389
makeBlackholeRoute<carbon::test::A::ARouterInfo>(
8490
RouteHandleFactory<carbon::test::A::ARouterInfo::RouteHandleIf>& factory,
@@ -169,6 +175,7 @@ ARouterInfo::buildRouteMap() {
169175
{"AllInitialRoute", &makeAllInitialRoute<ARouterInfo>},
170176
{"AllMajorityRoute", &makeAllMajorityRoute<ARouterInfo>},
171177
{"AllSyncRoute", &makeAllSyncRoute<ARouterInfo>},
178+
{"BigValueRoute", &makeBigValueRoute<ARouterInfo>},
172179
{"BlackholeRoute", &makeBlackholeRoute<ARouterInfo>},
173180
{"DevNullRoute", &makeDevNullRoute<ARouterInfo>},
174181
{"ErrorRoute", &makeErrorRoute<ARouterInfo>},

‎mcrouter/lib/carbon/test/gen/BRouterInfo-ExternTemplate.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <mcrouter/routes/AllInitialRouteFactory.h>
2424
#include <mcrouter/routes/AllMajorityRouteFactory.h>
2525
#include <mcrouter/routes/AllSyncRouteFactory.h>
26+
#include <mcrouter/routes/BigValueRoute.h>
2627
#include <mcrouter/routes/BlackholeRoute.h>
2728
#include <mcrouter/routes/DevNullRoute.h>
2829
#include <mcrouter/routes/ErrorRoute.h>
@@ -69,6 +70,11 @@ makeAllSyncRoute<carbon::test::B::BRouterInfo>(
6970
RouteHandleFactory<carbon::test::B::BRouterInfo::RouteHandleIf>& factory,
7071
const folly::dynamic& json);
7172

73+
template carbon::test::B::BRouterInfo::RouteHandlePtr
74+
makeBigValueRoute<carbon::test::B::BRouterInfo>(
75+
RouteHandleFactory<carbon::test::B::BRouterInfo::RouteHandleIf>& factory,
76+
const folly::dynamic& json);
77+
7278
template carbon::test::B::BRouterInfo::RouteHandlePtr
7379
makeBlackholeRoute<carbon::test::B::BRouterInfo>(
7480
RouteHandleFactory<carbon::test::B::BRouterInfo::RouteHandleIf>& factory,

‎mcrouter/lib/carbon/test/gen/BRouterInfo.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <mcrouter/routes/AllInitialRouteFactory.h>
2929
#include <mcrouter/routes/AllMajorityRouteFactory.h>
3030
#include <mcrouter/routes/AllSyncRouteFactory.h>
31+
#include <mcrouter/routes/BigValueRoute.h>
3132
#include <mcrouter/routes/BlackholeRoute.h>
3233
#include <mcrouter/routes/DevNullRoute.h>
3334
#include <mcrouter/routes/ErrorRoute.h>
@@ -79,6 +80,11 @@ makeAllSyncRoute<carbon::test::B::BRouterInfo>(
7980
RouteHandleFactory<carbon::test::B::BRouterInfo::RouteHandleIf>& factory,
8081
const folly::dynamic& json);
8182

83+
extern template carbon::test::B::BRouterInfo::RouteHandlePtr
84+
makeBigValueRoute<carbon::test::B::BRouterInfo>(
85+
RouteHandleFactory<carbon::test::B::BRouterInfo::RouteHandleIf>& factory,
86+
const folly::dynamic& json);
87+
8288
extern template carbon::test::B::BRouterInfo::RouteHandlePtr
8389
makeBlackholeRoute<carbon::test::B::BRouterInfo>(
8490
RouteHandleFactory<carbon::test::B::BRouterInfo::RouteHandleIf>& factory,
@@ -169,6 +175,7 @@ BRouterInfo::buildRouteMap() {
169175
{"AllInitialRoute", &makeAllInitialRoute<BRouterInfo>},
170176
{"AllMajorityRoute", &makeAllMajorityRoute<BRouterInfo>},
171177
{"AllSyncRoute", &makeAllSyncRoute<BRouterInfo>},
178+
{"BigValueRoute", &makeBigValueRoute<BRouterInfo>},
172179
{"BlackholeRoute", &makeBlackholeRoute<BRouterInfo>},
173180
{"DevNullRoute", &makeDevNullRoute<BRouterInfo>},
174181
{"ErrorRoute", &makeErrorRoute<BRouterInfo>},

‎mcrouter/lib/carbon/test/gen/CarbonTestRouterInfo-ExternTemplate.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <mcrouter/routes/AllInitialRouteFactory.h>
2424
#include <mcrouter/routes/AllMajorityRouteFactory.h>
2525
#include <mcrouter/routes/AllSyncRouteFactory.h>
26+
#include <mcrouter/routes/BigValueRoute.h>
2627
#include <mcrouter/routes/BlackholeRoute.h>
2728
#include <mcrouter/routes/DevNullRoute.h>
2829
#include <mcrouter/routes/ErrorRoute.h>
@@ -69,6 +70,11 @@ makeAllSyncRoute<carbon::test::CarbonTestRouterInfo>(
6970
RouteHandleFactory<carbon::test::CarbonTestRouterInfo::RouteHandleIf>& factory,
7071
const folly::dynamic& json);
7172

73+
template carbon::test::CarbonTestRouterInfo::RouteHandlePtr
74+
makeBigValueRoute<carbon::test::CarbonTestRouterInfo>(
75+
RouteHandleFactory<carbon::test::CarbonTestRouterInfo::RouteHandleIf>& factory,
76+
const folly::dynamic& json);
77+
7278
template carbon::test::CarbonTestRouterInfo::RouteHandlePtr
7379
makeBlackholeRoute<carbon::test::CarbonTestRouterInfo>(
7480
RouteHandleFactory<carbon::test::CarbonTestRouterInfo::RouteHandleIf>& factory,

‎mcrouter/lib/carbon/test/gen/CarbonTestRouterInfo.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <mcrouter/routes/AllInitialRouteFactory.h>
2929
#include <mcrouter/routes/AllMajorityRouteFactory.h>
3030
#include <mcrouter/routes/AllSyncRouteFactory.h>
31+
#include <mcrouter/routes/BigValueRoute.h>
3132
#include <mcrouter/routes/BlackholeRoute.h>
3233
#include <mcrouter/routes/DevNullRoute.h>
3334
#include <mcrouter/routes/ErrorRoute.h>
@@ -79,6 +80,11 @@ makeAllSyncRoute<carbon::test::CarbonTestRouterInfo>(
7980
RouteHandleFactory<carbon::test::CarbonTestRouterInfo::RouteHandleIf>& factory,
8081
const folly::dynamic& json);
8182

83+
extern template carbon::test::CarbonTestRouterInfo::RouteHandlePtr
84+
makeBigValueRoute<carbon::test::CarbonTestRouterInfo>(
85+
RouteHandleFactory<carbon::test::CarbonTestRouterInfo::RouteHandleIf>& factory,
86+
const folly::dynamic& json);
87+
8288
extern template carbon::test::CarbonTestRouterInfo::RouteHandlePtr
8389
makeBlackholeRoute<carbon::test::CarbonTestRouterInfo>(
8490
RouteHandleFactory<carbon::test::CarbonTestRouterInfo::RouteHandleIf>& factory,
@@ -168,6 +174,7 @@ CarbonTestRouterInfo::buildRouteMap() {
168174
{"AllInitialRoute", &makeAllInitialRoute<CarbonTestRouterInfo>},
169175
{"AllMajorityRoute", &makeAllMajorityRoute<CarbonTestRouterInfo>},
170176
{"AllSyncRoute", &makeAllSyncRoute<CarbonTestRouterInfo>},
177+
{"BigValueRoute", &makeBigValueRoute<CarbonTestRouterInfo>},
171178
{"BlackholeRoute", &makeBlackholeRoute<CarbonTestRouterInfo>},
172179
{"DevNullRoute", &makeDevNullRoute<CarbonTestRouterInfo>},
173180
{"ErrorRoute", &makeErrorRoute<CarbonTestRouterInfo>},

‎mcrouter/lib/carbon/test/gen/CarbonThriftTestRouterInfo-ExternTemplate.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <mcrouter/routes/AllInitialRouteFactory.h>
2424
#include <mcrouter/routes/AllMajorityRouteFactory.h>
2525
#include <mcrouter/routes/AllSyncRouteFactory.h>
26+
#include <mcrouter/routes/BigValueRoute.h>
2627
#include <mcrouter/routes/BlackholeRoute.h>
2728
#include <mcrouter/routes/DevNullRoute.h>
2829
#include <mcrouter/routes/ErrorRoute.h>
@@ -69,6 +70,11 @@ makeAllSyncRoute<carbon::test::CarbonThriftTestRouterInfo>(
6970
RouteHandleFactory<carbon::test::CarbonThriftTestRouterInfo::RouteHandleIf>& factory,
7071
const folly::dynamic& json);
7172

73+
template carbon::test::CarbonThriftTestRouterInfo::RouteHandlePtr
74+
makeBigValueRoute<carbon::test::CarbonThriftTestRouterInfo>(
75+
RouteHandleFactory<carbon::test::CarbonThriftTestRouterInfo::RouteHandleIf>& factory,
76+
const folly::dynamic& json);
77+
7278
template carbon::test::CarbonThriftTestRouterInfo::RouteHandlePtr
7379
makeBlackholeRoute<carbon::test::CarbonThriftTestRouterInfo>(
7480
RouteHandleFactory<carbon::test::CarbonThriftTestRouterInfo::RouteHandleIf>& factory,

‎mcrouter/lib/carbon/test/gen/CarbonThriftTestRouterInfo.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <mcrouter/routes/AllInitialRouteFactory.h>
2929
#include <mcrouter/routes/AllMajorityRouteFactory.h>
3030
#include <mcrouter/routes/AllSyncRouteFactory.h>
31+
#include <mcrouter/routes/BigValueRoute.h>
3132
#include <mcrouter/routes/BlackholeRoute.h>
3233
#include <mcrouter/routes/DevNullRoute.h>
3334
#include <mcrouter/routes/ErrorRoute.h>
@@ -79,6 +80,11 @@ makeAllSyncRoute<carbon::test::CarbonThriftTestRouterInfo>(
7980
RouteHandleFactory<carbon::test::CarbonThriftTestRouterInfo::RouteHandleIf>& factory,
8081
const folly::dynamic& json);
8182

83+
extern template carbon::test::CarbonThriftTestRouterInfo::RouteHandlePtr
84+
makeBigValueRoute<carbon::test::CarbonThriftTestRouterInfo>(
85+
RouteHandleFactory<carbon::test::CarbonThriftTestRouterInfo::RouteHandleIf>& factory,
86+
const folly::dynamic& json);
87+
8288
extern template carbon::test::CarbonThriftTestRouterInfo::RouteHandlePtr
8389
makeBlackholeRoute<carbon::test::CarbonThriftTestRouterInfo>(
8490
RouteHandleFactory<carbon::test::CarbonThriftTestRouterInfo::RouteHandleIf>& factory,
@@ -168,6 +174,7 @@ CarbonThriftTestRouterInfo::buildRouteMap() {
168174
{"AllInitialRoute", &makeAllInitialRoute<CarbonThriftTestRouterInfo>},
169175
{"AllMajorityRoute", &makeAllMajorityRoute<CarbonThriftTestRouterInfo>},
170176
{"AllSyncRoute", &makeAllSyncRoute<CarbonThriftTestRouterInfo>},
177+
{"BigValueRoute", &makeBigValueRoute<CarbonThriftTestRouterInfo>},
171178
{"BlackholeRoute", &makeBlackholeRoute<CarbonThriftTestRouterInfo>},
172179
{"DevNullRoute", &makeDevNullRoute<CarbonThriftTestRouterInfo>},
173180
{"ErrorRoute", &makeErrorRoute<CarbonThriftTestRouterInfo>},

‎mcrouter/lib/network/gen/MemcacheRouterInfo-ExternTemplate.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <mcrouter/routes/AllInitialRouteFactory.h>
2424
#include <mcrouter/routes/AllMajorityRouteFactory.h>
2525
#include <mcrouter/routes/AllSyncRouteFactory.h>
26+
#include <mcrouter/routes/BigValueRoute.h>
2627
#include <mcrouter/routes/BlackholeRoute.h>
2728
#include <mcrouter/routes/DevNullRoute.h>
2829
#include <mcrouter/routes/ErrorRoute.h>
@@ -69,6 +70,11 @@ makeAllSyncRoute<facebook::memcache::MemcacheRouterInfo>(
6970
RouteHandleFactory<facebook::memcache::MemcacheRouterInfo::RouteHandleIf>& factory,
7071
const folly::dynamic& json);
7172

73+
template facebook::memcache::MemcacheRouterInfo::RouteHandlePtr
74+
makeBigValueRoute<facebook::memcache::MemcacheRouterInfo>(
75+
RouteHandleFactory<facebook::memcache::MemcacheRouterInfo::RouteHandleIf>& factory,
76+
const folly::dynamic& json);
77+
7278
template facebook::memcache::MemcacheRouterInfo::RouteHandlePtr
7379
makeBlackholeRoute<facebook::memcache::MemcacheRouterInfo>(
7480
RouteHandleFactory<facebook::memcache::MemcacheRouterInfo::RouteHandleIf>& factory,

‎mcrouter/lib/network/gen/MemcacheRouterInfo.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <mcrouter/routes/AllInitialRouteFactory.h>
2929
#include <mcrouter/routes/AllMajorityRouteFactory.h>
3030
#include <mcrouter/routes/AllSyncRouteFactory.h>
31+
#include <mcrouter/routes/BigValueRoute.h>
3132
#include <mcrouter/routes/BlackholeRoute.h>
3233
#include <mcrouter/routes/DevNullRoute.h>
3334
#include <mcrouter/routes/ErrorRoute.h>
@@ -79,6 +80,11 @@ makeAllSyncRoute<facebook::memcache::MemcacheRouterInfo>(
7980
RouteHandleFactory<facebook::memcache::MemcacheRouterInfo::RouteHandleIf>& factory,
8081
const folly::dynamic& json);
8182

83+
extern template facebook::memcache::MemcacheRouterInfo::RouteHandlePtr
84+
makeBigValueRoute<facebook::memcache::MemcacheRouterInfo>(
85+
RouteHandleFactory<facebook::memcache::MemcacheRouterInfo::RouteHandleIf>& factory,
86+
const folly::dynamic& json);
87+
8288
extern template facebook::memcache::MemcacheRouterInfo::RouteHandlePtr
8389
makeBlackholeRoute<facebook::memcache::MemcacheRouterInfo>(
8490
RouteHandleFactory<facebook::memcache::MemcacheRouterInfo::RouteHandleIf>& factory,
@@ -168,6 +174,7 @@ MemcacheRouterInfo::buildRouteMap() {
168174
{"AllInitialRoute", &makeAllInitialRoute<MemcacheRouterInfo>},
169175
{"AllMajorityRoute", &makeAllMajorityRoute<MemcacheRouterInfo>},
170176
{"AllSyncRoute", &makeAllSyncRoute<MemcacheRouterInfo>},
177+
{"BigValueRoute", &makeBigValueRoute<MemcacheRouterInfo>},
171178
{"BlackholeRoute", &makeBlackholeRoute<MemcacheRouterInfo>},
172179
{"DevNullRoute", &makeDevNullRoute<MemcacheRouterInfo>},
173180
{"ErrorRoute", &makeErrorRoute<MemcacheRouterInfo>},

‎mcrouter/routes/BigValueRoute-inl.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ folly::IOBuf BigValueRoute<RouterInfo>::createChunkKey(
441441
}
442442

443443
template <class RouterInfo>
444-
typename RouterInfo::RouteHandlePtr makeBigValueRoute(
444+
typename RouterInfo::RouteHandlePtr makeBigValueRouteInternal(
445445
typename RouterInfo::RouteHandlePtr rh,
446446
BigValueRouteOptions options) {
447447
return makeRouteHandleWithInfo<RouterInfo, BigValueRoute>(
@@ -454,6 +454,7 @@ typename RouterInfo::RouteHandlePtr makeBigValueRoute(
454454
const folly::dynamic& json) {
455455
checkLogic(json.isObject(), "BigValueRoute is not an object");
456456
checkLogic(json.count("target"), "BigValueRoute: Missing target parameter");
457+
457458
return makeRouteHandleWithInfo<RouterInfo, BigValueRoute>(
458459
factory.create(json["target"]), detail::parseBigValueRouteSettings(json));
459460
}

‎mcrouter/routes/McRouteHandleProvider.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#include "mcrouter/routes/AllInitialRouteFactory.h"
1616
#include "mcrouter/routes/AllMajorityRouteFactory.h"
1717
#include "mcrouter/routes/AllSyncRouteFactory.h"
18+
#include "mcrouter/routes/BigValueRoute.h"
1819
#include "mcrouter/routes/BlackholeRoute.h"
1920
#include "mcrouter/routes/CarbonLookasideRoute.h"
2021
#include "mcrouter/routes/DevNullRoute.h"
@@ -251,6 +252,7 @@ McRouteHandleProvider<MemcacheRouterInfo>::buildRouteMap() {
251252
{"AllInitialRoute", &makeAllInitialRoute<MemcacheRouterInfo>},
252253
{"AllMajorityRoute", &makeAllMajorityRoute<MemcacheRouterInfo>},
253254
{"AllSyncRoute", &makeAllSyncRoute<MemcacheRouterInfo>},
255+
{"BigValueRoute", &makeBigValueRoute<MemcacheRouterInfo>},
254256
{"BlackholeRoute", &makeBlackholeRoute<MemcacheRouterInfo>},
255257
{"CarbonLookasideRoute",
256258
&createCarbonLookasideRoute<

‎mcrouter/routes/ProxyRoute-inl.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ typename RouterInfo::RouteHandlePtr wrapWithBigValueRoute(
3232
routerOpts.big_value_split_threshold,
3333
routerOpts.big_value_batch_size,
3434
routerOpts.big_value_hide_reply_flag);
35-
return makeBigValueRoute<RouterInfo>(std::move(ch), std::move(options));
35+
return makeBigValueRouteInternal<RouterInfo>(
36+
std::move(ch), std::move(options));
3637
}
3738

3839
} // namespace detail

0 commit comments

Comments
 (0)