Rename tlsClientIdentifier --> clientIdentityHash

Summary: Renaming since we are using CAT identities when present in the request - so it is not necessarily only tls conn identities

Reviewed By: stuclar

Differential Revision: D71329504

fbshipit-source-id: 1af953d6b96c256c4c7ac189c90a6a463f01634d

Author: Hiral Singadia

mcrouter/ServerOnRequest.h

@@ -175,13 +175,14 @@ class ServerOnRequest {
         ctxRef.getThriftRequestContext()) {
       auto mayBeHashedIdentities =
           core_infra_security::thrift_authentication_module::
-              ClientIdentifierHelper::getTlsClientIdentifier(
+              ClientIdentifierHelper::getClientIdentityHash(
                   *ctxRef.getThriftRequestContext());
       // if has valid hashed identity string, set it on the request
-      if (mayBeHashedIdentities.hasValue() &&
-          std::holds_alternative<std::string>(mayBeHashedIdentities.value())) {
+      if (mayBeHashedIdentities.has_value() &&
+          mayBeHashedIdentities->hasValue() &&
+          std::holds_alternative<std::string>(mayBeHashedIdentities->value())) {
         reqRef.setClientIdentifier(
-            std::get<std::string>(mayBeHashedIdentities.value()));
+            std::get<std::string>(mayBeHashedIdentities->value()));
       }
     }
 #endif