Skip to content

Commit 48cb8d3

Browse files
adamjernstMartin Konicek
authored and
Martin Konicek
committed
Start exposing RCTWebSocketObserver using a protocol
Reviewed By: javache Differential Revision: D4296387 fbshipit-source-id: 33f92c36168dcb18356d0ccdaf902a84634d94b7
1 parent 7a8410b commit 48cb8d3

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

Libraries/WebSocket/RCTWebSocketManager.h

+3
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212

1313
#if RCT_DEV // Only supported in dev mode
1414

15+
@interface RCTWebSocketObserver : NSObject <RCTWebSocketObserver>
16+
@end
17+
1518
@interface RCTWebSocketManager : NSObject <RCTWebSocketProxy>
1619
@end
1720

Libraries/WebSocket/RCTWebSocketManager.m

+5-8
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,15 @@
2020

2121
#pragma mark - RCTWebSocketObserver
2222

23-
@interface RCTWebSocketObserver : NSObject <RCTSRWebSocketDelegate> {
23+
@interface RCTWebSocketObserver () <RCTSRWebSocketDelegate>
24+
@end
25+
26+
@implementation RCTWebSocketObserver {
2427
NSURL *_url;
2528
RCTSRWebSocket *_socket;
2629
}
2730

28-
- (instancetype)initWithURL:(NSURL *)url;
29-
30-
@property (nonatomic, weak) id<RCTWebSocketProxyDelegate> delegate;
31-
32-
@end
33-
34-
@implementation RCTWebSocketObserver
31+
@synthesize delegate = _delegate;
3532

3633
- (instancetype)initWithURL:(NSURL *)url
3734
{

React/Base/RCTWebSocketProxy.h

+7
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@
1212

1313
#if RCT_DEV // Only supported in dev mode
1414

15+
@protocol RCTWebSocketProxyDelegate;
16+
17+
@protocol RCTWebSocketObserver
18+
- (instancetype)initWithURL:(NSURL *)url;
19+
@property (nonatomic, weak) id<RCTWebSocketProxyDelegate> delegate;
20+
@end
21+
1522
@protocol RCTWebSocketProxy
1623

1724
+ (instancetype)sharedInstance;

0 commit comments

Comments
 (0)