Skip to content

Commit 4fc2886

Browse files
Gyrangrabbou
authored andcommitted
exclude React/Fabric/ from core
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. <!-- Required: Write your motivation here. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. --> React native does not build on iOS when using Podspec environment. I tried the solution proposed in #18683 and got it to build. Fixes #18683 <!-- Required: Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! --> <!-- Does this PR require a documentation change? Create a PR at https://github.com/facebook/react-native-website and add a link to it here. --> <!-- Required. Help reviewers and the release process by writing your own release notes. See below for an example. --> [IOS] [BUGFIX] [React.podspec] - Exclude `React/Fabric/*` from Core subspec <!-- **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [ {Component} ] [ INTERNAL ] [ ENHANCEMENT ] [ {Filename} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Closes #18688 Differential Revision: D7505267 Pulled By: hramos fbshipit-source-id: 8e7138ee966d08209a74193e418feaecceefb86a
1 parent a05f851 commit 4fc2886

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

React.podspec

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ Pod::Spec.new do |s|
5151
"React/Inspector/*",
5252
"ReactCommon/yoga/*",
5353
"React/Cxx*/*",
54+
"React/Fabric/*",
5455
ss.ios.exclude_files = "React/**/RCTTV*.*"
5556
ss.tvos.exclude_files = "React/Modules/RCTClipboard*",
5657
"React/Views/RCTDatePicker*",

0 commit comments

Comments
 (0)